qa: Restore bitcoin-util-test py2 compatibility#11433
Merged
maflcko merged 1 commit intobitcoin:masterfrom Oct 3, 2017
Merged
Conversation
Member
|
utACK fafff12 |
3 tasks
Contributor
|
Tested ACK fafff12. Works with py2 and py3 for me. Out of interest, what are the plans for deprecating py2 for |
Member
Author
|
I am not against deprecating py2, but we should do it properly such that |
maflcko
pushed a commit
that referenced
this pull request
Oct 3, 2017
fafff12 qa: Restore bitcoin-util-test py2 compatibility (MarcoFalke) Pull request description: Currently `./configure && make check` will look for python3, then python2. As long as we support python2 (and use it as fallback), `make check` should run fine with both python2 and python3. Fixes #11352 by @Zenitur Tree-SHA512: a335ebdd224328d6f924fe52a9b97de196926476c9ee04ce3280743ea93bcae355eb2d5d4bed4050c01b2e904105595eac7db2eaa9307207581caa0a98ebcc0b
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 4, 2017
Github-Pull: bitcoin#11433 Rebased-From: fafff12
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 24, 2019
fafff12 qa: Restore bitcoin-util-test py2 compatibility (MarcoFalke) Pull request description: Currently `./configure && make check` will look for python3, then python2. As long as we support python2 (and use it as fallback), `make check` should run fine with both python2 and python3. Fixes bitcoin#11352 by @Zenitur Tree-SHA512: a335ebdd224328d6f924fe52a9b97de196926476c9ee04ce3280743ea93bcae355eb2d5d4bed4050c01b2e904105595eac7db2eaa9307207581caa0a98ebcc0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
./configure && make checkwill look for python3, then python2. As long as we support python2 (and use it as fallback),make checkshould run fine with both python2 and python3.Fixes #11352 by @Zenitur