[RPC] Don't do slow transaction lookup when txindex is enabled#11507
Closed
achow101 wants to merge 1 commit intobitcoin:masterfrom
Closed
[RPC] Don't do slow transaction lookup when txindex is enabled#11507achow101 wants to merge 1 commit intobitcoin:masterfrom
achow101 wants to merge 1 commit intobitcoin:masterfrom
Conversation
achow101
changed the title
Member
|
Concept ACK |
1 similar comment
Contributor
|
Concept ACK |
Member
|
This change makes a lot of sense IMO, congratulations on doing it in a single-line change. |
Contributor
|
True, utACK 8047f36. |
Member
|
Closing in favor of #11529 (sorry for the review churn) |
laanwj
added a commit
that referenced
this pull request
Oct 19, 2017
7a5f930 Avoid slow transaction search with txindex enabled (João Barbosa) Pull request description: This is an alternative to #11507 where a slow search is not attempted (in any case) if `txindex` is enabled. Tree-SHA512: e680621781a9241c0513ddd79d23b0b42f3ccec8a63ed1c926b35c43321c81c39a1028770397dd5070501dcf644d897026a2bd68a161a4b435f19227c1bbca48
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Nov 19, 2017
7a5f930 Avoid slow transaction search with txindex enabled (João Barbosa) Pull request description: This is an alternative to bitcoin#11507 where a slow search is not attempted (in any case) if `txindex` is enabled. Tree-SHA512: e680621781a9241c0513ddd79d23b0b42f3ccec8a63ed1c926b35c43321c81c39a1028770397dd5070501dcf644d897026a2bd68a161a4b435f19227c1bbca48
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Dec 26, 2018
7a5f930 Avoid slow transaction search with txindex enabled (João Barbosa) Pull request description: This is an alternative to bitcoin#11507 where a slow search is not attempted (in any case) if `txindex` is enabled. Tree-SHA512: e680621781a9241c0513ddd79d23b0b42f3ccec8a63ed1c926b35c43321c81c39a1028770397dd5070501dcf644d897026a2bd68a161a4b435f19227c1bbca48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
getrawtransaction, instead of always doing the slow transaction lookup, only do it when txindex is disabled.Partially fixes #11506