wallet: Add missing cs_wallet locks when accessing m_last_block_processed#11754
Closed
practicalswift wants to merge 1 commit intobitcoin:masterfrom
Closed
wallet: Add missing cs_wallet locks when accessing m_last_block_processed#11754practicalswift wants to merge 1 commit intobitcoin:masterfrom
practicalswift wants to merge 1 commit intobitcoin:masterfrom
Conversation
Member
|
Since this helps review, might as well add the |
practicalswift
force-pushed
the
missing-m_last_block_processed-locks
branch
from
77f1239 to
e9d0a71
Compare
Contributor
Author
|
@MarcoFalke Good idea! Fixed and pushed :-) |
m_last_block_processed is guarded by cs_wallet. These changes are required to get the Travis CI build (the build job with Clang's thread safety analysis enabled) to pass when the following locking annotation is added: ``` const CBlockIndex* m_last_block_processed GUARDED_BY(cs_wallet); ```
practicalswift
force-pushed
the
missing-m_last_block_processed-locks
branch
from
e9d0a71 to
e737100
Compare
practicalswift
changed the title
Contributor
|
|
Contributor
|
Sorry @practicalswift, it's a NACK. At the moment Lines 1280 to 1282 in 85123be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing
cs_walletlocks when accessingm_last_block_processed.m_last_block_processedis guarded bycs_wallet.These changes are required to get the Travis CI build (the build job with Clang's thread safety analysis enabled) to pass when the following locking annotation (see #11226) is added: