[depends] Fix Qt build with Xcode 9#11995
Merged
laanwj merged 1 commit intobitcoin:masterfrom Mar 5, 2018
Merged
Conversation
eugene-sy
added a commit
to meritlabs/merit
that referenced
this pull request
Jan 11, 2018
initially found in bitcoin repo bitcoin/bitcoin#11995
Member
What is the status of this? |
Member
|
Looks like this is for backport? |
Member
Member
Strange! That seems related to sse4 instructions support, not Qt. Do you have the same problem without this change? |
theuni
approved these changes
Mar 5, 2018
Member
theuni
left a comment
theuni
left a comment
There was a problem hiding this comment.
As discussed in-person, build failure looks unrelated. utACK after switching to a patch from upstream qt's git.
fanquake
force-pushed
the
macos-10-13-fix-depends-qt
branch
from
c38960e to
2b1f794
Compare
Member
Author
|
Updated to use an upstream patch. See https://bugreports.qt.io/browse/QTBUG-63401 & https://codereview.qt-project.org/gitweb?p=qt/qtbase.git;a=patch;h=0707260a4f8e64dfadf1df5f935e74cabb7c7d27. |
Member
|
utACK 2b1f794 |
laanwj
added a commit
that referenced
this pull request
Mar 5, 2018
2b1f794 [Depends] Fix Qt build with Xcode 9.2 (fanquake) Pull request description: Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim. Fixes #11461 Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266. Tree-SHA512: b1aaa50580c5180bbae2d79f5618c145667edd824b66c20851c7346674a1700267d6df249ba559d781941def312f7867bc3950f673e9128ffd4beda2965ca639
Member
|
I can't reproduce my issue with a fresh clone and it went away with |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 11, 2018
GitHub-Pull: bitcoin#11995 Rebased-From: 2b1f794
laanwj
added a commit
that referenced
this pull request
Mar 14, 2018
f3b8d85 devtools: Exclude patches from lint-whitespace GitHub-Pull: #12442 Rebased-From: fafbf7f (MarcoFalke) 686cb86 [Depends] Fix Qt build with Xcode 9.2 (fanquake) Pull request description: GitHub-Pull: #11995 Rebased-From: 2b1f794 Tree-SHA512: 73d1c0a87fd135f3ad8bb737b97037ef047e582c41a7473833e82776957caf372fcd0caa764fc4eed792e9998e214ae829bad5535db6d589827085a74b0fa6f4
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Mar 16, 2018
GitHub-Pull: bitcoin#11995 Rebased-From: 2b1f794
Member
Author
|
Removed "Needs Backport" as it was done in #12636. |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 26, 2018
GitHub-Pull: bitcoin#11995 Rebased-From: 2b1f794
laanwj
added a commit
that referenced
this pull request
May 15, 2018
93b9a61 depends: Fix Qt build with XCode 9.3 (fanquake) 9bb1a16 [Depends] Fix Qt build with Xcode 9.2 (fanquake) Pull request description: Backports #11995 and #12946 so that qt (and all depends) can still be built on the 0.15 branch. Tree-SHA512: 671cce790b5f72c8edd04461d0bc3d300557c4df8c4e5d338561a972333edb34e2009f221d581fe3b2e61080cce0891588831c00c16d4ab852730f65856a3054
XNotCopy
pushed a commit
to DigitalToaster/ReducedBitcoin
that referenced
this pull request
Jun 21, 2018
GitHub-Pull: bitcoin#11995 Rebased-From: 2b1f794
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Sep 26, 2018
GitHub-Pull: bitcoin#11995 Rebased-From: 2b1f794
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Sep 30, 2018
* [Depends] Fix Qt build with Xcode 9.2 GitHub-Pull: bitcoin#11995 Rebased-From: 2b1f794 * depends: Fix Qt build with XCode 9.3 GitHub-Pull: bitcoin#12946 Rebased-From: 5b4fc3e * add newline
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 13, 2019
* [Depends] Fix Qt build with Xcode 9.2 GitHub-Pull: bitcoin#11995 Rebased-From: 2b1f794 * depends: Fix Qt build with XCode 9.3 GitHub-Pull: bitcoin#12946 Rebased-From: 5b4fc3e * add newline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.
Fixes #11461
Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.