Improve getchaintxstats test coverage#12083
Merged
laanwj merged 2 commits intobitcoin:masterfrom Feb 26, 2018
Merged
Conversation
promag
force-pushed
the
2018-01-getchaintxstats
branch
3 times, most recently
from
a5667a3 to
5b95f96
Compare
ajtowns
approved these changes
Jan 11, 2018
Contributor
ajtowns
left a comment
ajtowns
left a comment
There was a problem hiding this comment.
ACK 5b95f96871a33aada918c54c4eff263cb3c55fec -- refactoring looks like it shouldn't change the logic; extra test cases look good.
test/functional/blockchain.py
Outdated
Contributor
There was a problem hiding this comment.
Wouldn't it be better to do:
blockhash = self.nodes[0].getblockhash(200)
self.nodes[0].invalidateblock(blockhash)
assert_raises_rpc_error()
self.nodes[0].reconsiderblock(blockhash)
and drop the invalidateblock in _test_gettxoutsetinfo()?
Contributor
Author
There was a problem hiding this comment.
Done, I'll squash once it's green.
Contributor
Author
|
@ajtowns Thanks for the review.
If this is a concern for others, I can take that commit to a new PR. |
ryanofsky
reviewed
Feb 5, 2018
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
utACK 590aa8f1b56cf1a8d82bff41a513cf5f3f530e4a
promag
force-pushed
the
2018-01-getchaintxstats
branch
from
590aa8f to
e805507
Compare
promag
force-pushed
the
2018-01-getchaintxstats
branch
from
e805507 to
57e6786
Compare
Contributor
Author
|
Rebased to fix conflict of test file Best reviewed with |
laanwj
added a commit
that referenced
this pull request
Feb 26, 2018
57e6786 qa: Improve getchaintxstats functional test (João Barbosa) 501b439 rpc: Refactor blockhash parse in getchaintxstats (João Barbosa) Pull request description: Tree-SHA512: 61dec5cb68122998df7ec7b5239830f3caf0fe7185c107a66f27653ab2531a800db19a09050671b6fa8dbb5b53181da861eb31199c79d8635f246ccfa0d10efd
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 14, 2020
57e6786 qa: Improve getchaintxstats functional test (João Barbosa) 501b439 rpc: Refactor blockhash parse in getchaintxstats (João Barbosa) Pull request description: Tree-SHA512: 61dec5cb68122998df7ec7b5239830f3caf0fe7185c107a66f27653ab2531a800db19a09050671b6fa8dbb5b53181da861eb31199c79d8635f246ccfa0d10efd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.