Avoid permanent cs_main lock in getblockheader#12153
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jan 8, 2019
Merged
Conversation
promag
force-pushed
the
2018-01-getblockheader
branch
from
3062a36 to
d22e406
Compare
promag
force-pushed
the
2018-01-getblockheader
branch
4 times, most recently
from
7bb7175 to
5e924f4
Compare
ryanofsky
reviewed
Feb 5, 2018
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
utACK last commit only 5e924f4d22a16b0c46d4c6cb19877892331d41fa (previous commits are from base PR)
Contributor
|
needs rebase (but probably not worth doing until #12151 is merged) |
promag
force-pushed
the
2018-01-getblockheader
branch
2 times, most recently
from
e167a84 to
ba2dad1
Compare
Closed
promag
force-pushed
the
2018-01-getblockheader
branch
from
ba2dad1 to
4572a39
Compare
Contributor
Author
|
Rebased. |
maflcko
reviewed
Jan 4, 2019
promag
force-pushed
the
2018-01-getblockheader
branch
from
4572a39 to
f12e1d0
Compare
Member
|
utACK f12e1d0 |
Member
|
So to be clear: this is can be done, because it is safe to access the fields on the CBlockIndex instance without the lock? |
Contributor
Author
|
@laanwj to best of my knowledge yes. Looks like |
Contributor
|
utACK f12e1d0. Do you intend to do the same for |
laanwj
added a commit
that referenced
this pull request
Jan 8, 2019
f12e1d0 rpc: Avoid permanent cs_main lock in getblockheader (João Barbosa) Pull request description: This PR reduces the `cs_main` lock scope in `getblockheader` RPC. Tree-SHA512: bc51f80e15d1b32d3c7886836457f9929706b6aad9841dafce31ffca444281471b21b56192bb50de774184b9377412f815ad8d3d2439049a7e64d2e59c415767
Contributor
Author
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Apr 29, 2021
zcash: cherry picked from commit f12e1d0 zcash: bitcoin/bitcoin#12153
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Jun 1, 2021
zcash: cherry picked from commit f12e1d0 zcash: bitcoin/bitcoin#12153
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Aug 24, 2021
f12e1d0 rpc: Avoid permanent cs_main lock in getblockheader (João Barbosa) Pull request description: This PR reduces the `cs_main` lock scope in `getblockheader` RPC. Tree-SHA512: bc51f80e15d1b32d3c7886836457f9929706b6aad9841dafce31ffca444281471b21b56192bb50de774184b9377412f815ad8d3d2439049a7e64d2e59c415767
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 24, 2021
f12e1d0 rpc: Avoid permanent cs_main lock in getblockheader (João Barbosa) Pull request description: This PR reduces the `cs_main` lock scope in `getblockheader` RPC. Tree-SHA512: bc51f80e15d1b32d3c7886836457f9929706b6aad9841dafce31ffca444281471b21b56192bb50de774184b9377412f815ad8d3d2439049a7e64d2e59c415767
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the
cs_mainlock scope ingetblockheaderRPC.