trivial: fix address_type help text of getnewaddress and getrawchangeaddress#12177
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jan 16, 2018
Merged
trivial: fix address_type help text of getnewaddress and getrawchangeaddress#12177maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
ghost
approved these changes
Jan 13, 2018
Contributor
|
ACK 5f911c5 |
Member
|
ACK 5f911c5 |
Contributor
|
ACK 5f911c5. |
maflcko
pushed a commit
that referenced
this pull request
Jan 16, 2018
…d getrawchangeaddress 5f911c5 trivial: fix address_type help text of getnewaddress and getrawchangeaddress (mruddy) Pull request description: "p2sh" in the help messages should have been "p2sh-segwit". The messages before this patch: `help getnewaddress` "address_type" (string, optional) The address type to use. Options are "legacy", "**p2sh**", and "bech32". Default is set by -addresstype. `help getrawchangeaddress` "address_type" (string, optional) The address type to use. Options are "legacy", "**p2sh**", and "bech32". Default is set by -changetype. Tree-SHA512: 6dfc0bebe577995f5521b83a12854045ac3eda4e65c9b92fc581da4ee68ab1218e05af82f2154bb2640a0813c5f79e010cd9e5ada449494c8831b3757bda854c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"p2sh" in the help messages should have been "p2sh-segwit".
The messages before this patch:
help getnewaddress"address_type" (string, optional) The address type to use. Options are "legacy", "p2sh", and "bech32". Default is set by -addresstype.
help getrawchangeaddress"address_type" (string, optional) The address type to use. Options are "legacy", "p2sh", and "bech32". Default is set by -changetype.