scripted-diff: prefix [address|change]type parameters with 'default'#12216
scripted-diff: prefix [address|change]type parameters with 'default'#12216Sjors wants to merge 1 commit intobitcoin:masterfrom
Conversation
Making it clear that these parameters can be overridden by individual wallet commands. -BEGIN VERIFY SCRIPT- sed -i 's/addresstype/defaultaddresstype/g' doc/*.md src/wallet/*.cpp test/functional/*.py sed -i 's/changetype/defaultchangetype/g' doc/*.md src/wallet/*.cpp test/functional/*.py -END VERIFY SCRIPT-
Sjors
force-pushed
the
2018/01/defaultaddresstype
branch
from
a71d991 to
e47af54
Compare
|
@MarcoFalke this changes more than just docs, probably needs a wallet and RPC label. |
| std::string GetWalletHelpString(bool showDebug) | ||
| { | ||
| std::string strUsage = HelpMessageGroup(_("Wallet options:")); | ||
| strUsage += HelpMessageOpt("-addresstype", strprintf(_("What type of addresses to use (\"legacy\", \"p2sh-segwit\", or \"bech32\", default: \"%s\")"), FormatOutputType(OUTPUT_TYPE_DEFAULT))); |
There was a problem hiding this comment.
I would rather improve the description.
BTW, currently RPC help is very clear:
bitcoin/src/wallet/rpcwallet.cpp
Line 147 in 898f560
Reasons for rename:
1) Default value is `<datadir>/wallets` so calling it `-walletsdir` instead
of `-walletdir` would be more internally consistent
2) Directory can contain more than one wallet so plural makes more sense
3) This makes it harder to confuse -walletdir option with -wallet option
if we store wallets in their own directories as proposed in
bitcoin#11466 (comment) and
implemented in bitcoin#12216
-BEGIN VERIFY SCRIPT-
git grep -l walletdir | xargs sed -i s/walletdir/walletsdir/g
-END VERIFY SCRIPT-
|
Removing this from 0.16 milestone - during the IRC meeting it was found that many options apply to defaults, so adding |
|
Should be closed then because changing the arguments after a release is a no-go. |
|
Agree with the above, as well as @laanwj's point "shorter option names are easier to remember/type". The behavior of these parameters did lead to some confusion during code review, but with the proper docs hopefully it will be fine for users. |
6 participants
Making it clear that these parameters can be overridden by individual wallet commands.
Requesting 0.16 tag, as it's probably not worth changing otherwise.
This makes grateful use of the fact that @sipa used an underscore for
address_typeandchange_typeRPC arguments.