Fix Windows build errors introduced in #10498#12416
Merged
maflcko merged 1 commit intobitcoin:masterfrom Feb 12, 2018
Merged
Conversation
Member
|
utACK f40df29 |
Member
|
Tested on a Gitian VM: Build succeeds, but I do see some warnings (not sure if related), e.g.: I copied the executables over to a Windows 10 VM and was able to launch QT. |
maflcko
pushed a commit
that referenced
this pull request
Feb 12, 2018
f40df29 Fix Windows build errors introduced in #10498 (practicalswift) Pull request description: Fix Windows build errors introduced in #10498 Fixes #12386 cc @ken2812221, @Sjors, @MarcoFalke and @floreslorca Tree-SHA512: a807521fbd4015971e646fa4bab5495a3aaa97337e7b7d80b9161f33778e84ad6725cf4fbd5a35b50bf3a2bd97747cd7a630b51493ff516c2e1ad74acce148be
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 11, 2020
…0498 f40df29 Fix Windows build errors introduced in bitcoin#10498 (practicalswift) Pull request description: Fix Windows build errors introduced in bitcoin#10498 Fixes bitcoin#12386 cc @ken2812221, @Sjors, @MarcoFalke and @floreslorca Tree-SHA512: a807521fbd4015971e646fa4bab5495a3aaa97337e7b7d80b9161f33778e84ad6725cf4fbd5a35b50bf3a2bd97747cd7a630b51493ff516c2e1ad74acce148be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows build errors introduced in #10498
Fixes #12386
cc @ken2812221, @Sjors, @MarcoFalke and @floreslorca