[doc] dev-notes: Members should be initialized#12434
Merged
laanwj merged 1 commit intobitcoin:masterfrom Mar 5, 2018
Merged
Conversation
Contributor
|
ACK fa03f777880cbe245676a3ac4d5b22d2bc93dbe9 |
Contributor
|
ACK fa03f77 |
dcousens
approved these changes
Feb 14, 2018
Contributor
|
ACK fa03f77. |
laanwj
reviewed
Feb 15, 2018
doc/developer-notes.md
Outdated
Member
There was a problem hiding this comment.
You're talking about class members above, but using a struct here. I think there can be good (performance) arguments not to have an auto-generated constructor for a POD struct, so might be better to use a class for illustration.
Member
Author
There was a problem hiding this comment.
My opinion is that such cases should just be justified with a comment:
int a; // Not initialized for performance reasons.Also, remove mention of threads that were removed long ago
maflcko
force-pushed
the
Mf1802-docDevMemberInit
branch
from
fa03f77 to
fa94614
Compare
Member
|
utACK fa94614 |
laanwj
added a commit
that referenced
this pull request
Mar 5, 2018
fa94614 [doc] dev-notes: Members should be initialized (MarcoFalke) Pull request description: Also, remove mention of threads that were removed long ago. Motivation: Make it easier to spot bugs such as #11654 and #12426 Tree-SHA512: 8ca1cb54e830e9368803bd98a8b08c39bf2d46f079094ed7e070b32ae15a6e611ce98d7a614f897803309f4728575e6bc9357fab1157c53d2536417eb8271653
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 14, 2020
fa94614 [doc] dev-notes: Members should be initialized (MarcoFalke) Pull request description: Also, remove mention of threads that were removed long ago. Motivation: Make it easier to spot bugs such as bitcoin#11654 and bitcoin#12426 Tree-SHA512: 8ca1cb54e830e9368803bd98a8b08c39bf2d46f079094ed7e070b32ae15a6e611ce98d7a614f897803309f4728575e6bc9357fab1157c53d2536417eb8271653
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, remove mention of threads that were removed long ago.
Motivation:
Make it easier to spot bugs such as #11654 and #12426