qa: Fix python TypeError in script.py#12475
Merged
laanwj merged 1 commit intobitcoin:masterfrom Mar 5, 2018
Merged
Conversation
Contributor
|
ACK fa82cacf601acf7f92b51a6f870cb4f6bbfe92db |
fanquake
requested changes
Feb 19, 2018
Member
fanquake
left a comment
fanquake
left a comment
There was a problem hiding this comment.
Is this comment above now out of date? "For Python3 compatibility add b before strings so testcases don't need to change"
maflcko
force-pushed
the
Mf1802-qaPythonSyntax
branch
from
fa82cac to
fabc123
Compare
maflcko
force-pushed
the
Mf1802-qaPythonSyntax
branch
from
fabc123 to
fa41d68
Compare
Member
Author
|
Removed comment
…On Feb 18, 2018 21:57, "fanquake" ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Is this comment above now out of date? "For Python3 compatibility add b
before strings so testcases don't need to change"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12475 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv1_0JF7fqKhjCNDeB7IQJdHF0R1Aks5tWOMzgaJpZM4SJg99>
.
|
Member
|
utACK fa41d68 |
Member
|
utACK fa41d68 |
laanwj
added a commit
that referenced
this pull request
Mar 5, 2018
fa41d68 qa: Fix python TypeError in script.py (MarcoFalke) Pull request description: `__repr__` returns string, so don't mix it with byte strings. This fixes ``` TypeError: %b requires a bytes-like object, or an object that implements __bytes__, not 'str' Tree-SHA512: fac06e083f245209bc8a36102217580b0f6186842f4e52a686225111b0b96ff93c301640ff5e7ddef6a5b4f1689071b16a9a8dc80f28e2b060ddee29edd24ec7
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 20, 2018
Github-Pull: bitcoin#12475 Rebased-From: fa41d68
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
May 13, 2018
Github-Pull: bitcoin#12475 Rebased-From: fa41d68
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 24, 2020
fa41d68 qa: Fix python TypeError in script.py (MarcoFalke) Pull request description: `__repr__` returns string, so don't mix it with byte strings. This fixes ``` TypeError: %b requires a bytes-like object, or an object that implements __bytes__, not 'str' Tree-SHA512: fac06e083f245209bc8a36102217580b0f6186842f4e52a686225111b0b96ff93c301640ff5e7ddef6a5b4f1689071b16a9a8dc80f28e2b060ddee29edd24ec7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__repr__returns string, so don't mix it with byte strings.This fixes