[0.16] depends: Switch to downloading expat from GitHub#12585
Merged
maflcko merged 1 commit intobitcoin:0.16from Mar 5, 2018
Merged
[0.16] depends: Switch to downloading expat from GitHub#12585maflcko merged 1 commit intobitcoin:0.16from
maflcko merged 1 commit intobitcoin:0.16from
Conversation
Member
|
utACK 25afebc |
Contributor
|
utACK Am busy right now but will try to convert this to a tACK in the next couple of days. |
Contributor
|
utACK 25afebc |
maflcko
pushed a commit
that referenced
this pull request
Mar 5, 2018
25afebc depends: Switch expat download to GitHub (fanquake) Pull request description: @droark [mentioned](#12402 (comment)) the expat download was failing when trying to gitian build 0.16. I tried locally and also saw issues: ``` make download Checksum missing or mismatched for expat source. Forcing re-download. Fetching expat-2.2.1.tar.bz2 from https://downloads.sourceforge.net/project/expat/expat/2.2.1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0 100 652 100 652 0 0 361 0 0:00:01 0:00:01 --:--:-- 0 /Users/xxx/Github/bitcoin/depends/work/download/expat-2.2.1/expat-2.2.1.tar.bz2.temp: FAILED shasum: WARNING: 1 computed checksum did NOT match Fetching expat-2.2.1.tar.bz2 from https://bitcoincore.org/depends-sources % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found make[1]: *** [/Users/xxx/Github/bitcoin/depends/sources/download-stamps/.stamp_fetched-expat-expat-2.2.1.tar.bz2.hash] Error 22 make: *** [download-linux] Error 2 ``` This switches to downloading from GitHub, as we are doing in master. Tree-SHA512: 0e3072ce4d8fee3e2bc434afc7469968c21e01ca35aa2ccbffc25f8e9b00af2e4a5f3f9e4cd5c0cd8e72a10b16205236eb0536380849109a739c09358dbc1394
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@droark mentioned the expat download was failing when trying to gitian build 0.16.
I tried locally and also saw issues:
This switches to downloading from GitHub, as we are doing in master.