RPC: Support addnode onetry without making the connection priviliged#12674
RPC: Support addnode onetry without making the connection priviliged#12674luke-jr wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
rpc_net.py fails |
|
Concept ACK |
luke-jr
force-pushed
the
rpc_onetry_nonpriv
branch
from
c21d55a to
0670e4f
Compare
|
This breaks our outbound-connection-counting logic in the aut-connect loop as it uses the manual connection flag to figure out how many other connections to make. |
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
Why no PR description? What's the use case for this?
|
Added a PR description, and kicked Travis. |
|
Can you address @TheBlueMatt's comment here: #12674 (comment) ? |
|
@TheBlueMatt @sipa I don't consider that broken. A non-privileged connection should be treated the same as any other normal outgoing connection. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Rebased |
luke-jr
force-pushed
the
rpc_onetry_nonpriv
branch
from
0670e4f to
73891da
Compare
luke-jr
force-pushed
the
rpc_onetry_nonpriv
branch
from
73891da to
cd961a4
Compare
luke-jr
force-pushed
the
rpc_onetry_nonpriv
branch
from
cd961a4 to
7711302
Compare
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
Superceding with #20551 |
10 participants
The behaviour of addnode onetry changed without notice. This restores the ability to at least get the original behaviour.
Needed for properly testing DoS rules.