Merged
Conversation
Suggested by Sjors Provoost <[email protected]> in bitcoin#11536 (comment)
Member
|
Concept ACK. Ideally there would also be some comment next to each alias in places like |
Contributor
Author
What would the comment say, and why would it be helpful? The only non-obvious behavior I can think of regarding aliases is that they are omitted from the command listing in help text, and this doesn't seem like a relevant fact to mention in the middle of command registration. |
randolf
approved these changes
Mar 15, 2018
Contributor
|
ACK 4c317d8 |
Member
|
utACK 4c317d8. This is exactly the behavior that is desirable for deprecating/renaming RPCs, but needs to be documented. |
laanwj
added a commit
that referenced
this pull request
Mar 19, 2018
4c317d8 Document RPC method aliasing (Russell Yanofsky) Pull request description: Suggested by @Sjors in #11536 (comment) Tree-SHA512: 7bf16238e41b6c6c078e9103d8eac2ac76739a2c16b4f964be49bfde1f20f31a1fb30badf1faaa6ddc301a74f0d785d19567069b50de78c502144479143cb38c
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 17, 2020
4c317d8 Document RPC method aliasing (Russell Yanofsky) Pull request description: Suggested by @Sjors in bitcoin#11536 (comment) Tree-SHA512: 7bf16238e41b6c6c078e9103d8eac2ac76739a2c16b4f964be49bfde1f20f31a1fb30badf1faaa6ddc301a74f0d785d19567069b50de78c502144479143cb38c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @Sjors in #11536 (comment)