Fix typos and cleanup in various files#12716
Fix typos and cleanup in various files#12716maflcko merged 1 commit intobitcoin:masterfrom rex4539:fix-typos
Conversation
randolf
left a comment
randolf
left a comment
There was a problem hiding this comment.
These are excellent edits overall; please fix the following...
Line 4189 in src/wallet/wallet.cpp:
Please change "the just generated" to either "the just-generated" or "this newly generated" (I prefer the latter).
Line 358 in test/functional/wallet_basic.py:
Please revert this change.
|
@randolf Fixed :) |
|
utACK 8cd373190c1dafc3c6ea660990e72ff4d7f20734 As said before – I think the inclusion of the capitalization fixes in But utACK from me anyways :-) |
|
utACK 8cd3731. |
1 similar comment
|
utACK 8cd3731. |
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
sure. utACK with a couple of nits.
src/test/mempool_tests.cpp
Outdated
There was a problem hiding this comment.
nit: prefer 'we only require this to remove...' or 'we only require that this remove...'
test/functional/wallet_basic.py
Outdated
There was a problem hiding this comment.
nit: personal preference for broadcast as the past participle of broadcast (both are acceptable but broadcast appears to be more common: https://english.stackexchange.com/questions/33207/broadcast-or-broadcasted)
|
@jnewbery Fixed :) |
|
Re-utACK 4d9b425. |
|
re-utACK 4d9b425 |
4d9b425 Fix typos (Dimitris Apostolou) Pull request description: Unfortunately I messed up my repo while trying to squash #12593 so I created a PR with just the correct fixes. Tree-SHA512: 295d77b51bd2a9381f1802c263de7ffb2edd670d9647391e32f9a414705b3c8b483bb0e469a9b85ab6a70919ea13397fa8dfda2aea7a398b64b187f178fe6a06
| // state are returned in spacePadPositive (for space padded positive numbers) | ||
| // and ntrunc (for truncating conversions). argIndex is incremented if | ||
| // necessary to pull out variable width and precision . The function returns a | ||
| // necessary to pull out variable width and precision. The function returns a |
There was a problem hiding this comment.
Please submit the changes to this file upstream as well.
|
Nice to have this one merged! Reviewers of this PR might be interested in reviewing #12747 which contains a few typo fixes :-) |
Summary: 4d9b425 Fix typos (Dimitris Apostolou) Pull request description: Unfortunately I messed up my repo while trying to squash #12593 so I created a PR with just the correct fixes. Tree-SHA512: 295d77b51bd2a9381f1802c263de7ffb2edd670d9647391e32f9a414705b3c8b483bb0e469a9b85ab6a70919ea13397fa8dfda2aea7a398b64b187f178fe6a06 Backport of Core PR12716 bitcoin/bitcoin#12716 Test Plan: make check arc lint Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3805
4d9b425 Fix typos (Dimitris Apostolou) Pull request description: Unfortunately I messed up my repo while trying to squash bitcoin#12593 so I created a PR with just the correct fixes. Tree-SHA512: 295d77b51bd2a9381f1802c263de7ffb2edd670d9647391e32f9a414705b3c8b483bb0e469a9b85ab6a70919ea13397fa8dfda2aea7a398b64b187f178fe6a06 Signed-off-by: pasta <[email protected]>
4d9b425 Fix typos (Dimitris Apostolou) Pull request description: Unfortunately I messed up my repo while trying to squash bitcoin#12593 so I created a PR with just the correct fixes. Tree-SHA512: 295d77b51bd2a9381f1802c263de7ffb2edd670d9647391e32f9a414705b3c8b483bb0e469a9b85ab6a70919ea13397fa8dfda2aea7a398b64b187f178fe6a06 Signed-off-by: pasta <[email protected]>
8 participants
Unfortunately I messed up my repo while trying to squash #12593 so I created a PR with just the correct fixes.