Skip to content

Bugfix: Include <memory> for std::unique_ptr#12859

Merged
laanwj merged 1 commit intobitcoin:masterfrom
luke-jr:incl_memory
Apr 5, 2018
Merged

Bugfix: Include <memory> for std::unique_ptr#12859
laanwj merged 1 commit intobitcoin:masterfrom
luke-jr:incl_memory

Conversation

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Apr 2, 2018 •
edited
Loading

Not sure why all these includes were missing, but it's breaking builds for some users:

https://bugs.gentoo.org/show_bug.cgi?id=652142

(Added to all files with a reference to std::unique_ptr)

@randolf
Copy link
Contributor

randolf commented Apr 2, 2018

This doesn't compile on NetBSD 7.0 (64-bit), but the unmodified branch builds as expected. It seems that these updates prevent the check for "-ldb_cxx" from succeeding, even though Berkeley DB4 is already installed.

STEPS

git clone https://www.github.com/luke-jr/bitcoin
cd bitcoin
git checkout incl_memory
./autogen.sh
./configure CPPFLAGS="-I/usr/pkg/include" LDFLAGS="-L/usr/pkg/lib" BOOST_CPPFLAGS="-I/usr/pkg/include" BOOST_LDFLAGS="-L/usr/pkg/lib"

OUTCOME

checking for Berkeley DB C++ headers... /usr/pkg/include/db4/
checking for main in -ldb_cxx-4.8... no
checking for main in -ldb_cxx... no
configure: error: libdb_cxx missing, Bitcoin Core requires this library for wallet functionality (--disable-wallet to disable wallet functionality)

If a change is needed for the ./configure command, I'd be happy to add it to the documentation for the NetBSD installation instructions to accommodate this Pull Request.

Thanks.

@luke-jr
Copy link
Member Author

luke-jr commented Apr 2, 2018

Don't use PR branches directly (this one is based on the last common commit between 0.15 and master, for maximum merge-compatibility). Merge it into master to test.

(This shouldn't change anything during configure.)

@randolf
Copy link
Contributor

randolf commented Apr 2, 2018 •
edited
Loading

@luke-jr I'm still learning how to use git, et al., so I welcome any suggestions on the proper way to attempt to compile with your changes.

@luke-jr
Copy link
Member Author

luke-jr commented Apr 2, 2018 

git clone https://www.github.com/bitcoin/bitcoin
cd bitcoin
git fetch https://www.github.com/luke-jr/bitcoin incl_memory
git merge FETCH_HEAD
./autogen.sh
./configure CPPFLAGS="-I/usr/pkg/include" LDFLAGS="-L/usr/pkg/lib" BOOST_CPPFLAGS="-I/usr/pkg/include" BOOST_LDFLAGS="-L/usr/pkg/lib"

@randolf
Copy link
Contributor

randolf commented Apr 2, 2018

ACK.

@luke-jr Thanks, that worked, and it compiled successfully on NetBSD.

@luke-jr
Copy link
Member Author

luke-jr commented Apr 2, 2018

@fanquake This should be "Bug", not "Refactoring"...

@fanquake fanquake added Bug and removed Refactoring labels Apr 2, 2018
@promag
Copy link
Contributor

promag commented Apr 3, 2018

utACK a5bca13.

@sipa
Copy link
Member

sipa commented Apr 3, 2018

utACK a5bca13

@practicalswift
Copy link
Contributor

practicalswift commented Apr 4, 2018

utACK a5bca13. i686-w64-mingw32 build timeout is unrelated.

@laanwj laanwj merged commit a5bca13 into bitcoin:master Apr 5, 2018
@laanwj laanwj added this to the 0.16.2 milestone Jun 13, 2018
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jun 13, 2018
@luke-jr @fanquake
Bugfix: Include <memory> for std::unique_ptr
18b0c69 
GitHub-Pull: bitcoin#12859
Rebased-From: a5bca13
@fanquake fanquake mentioned this pull request Jun 13, 2018
Merged
@fanquake
Copy link
Member

fanquake commented Jun 26, 2018

Added to #13455 for backport.

laanwj added a commit that referenced this pull request Jul 9, 2018
@laanwj
Merge #13455: [0.16.2] Backports
dac5374 
9fd3e00 depends: Update Qt download url (fanquake)
f7401c8 Fix parameter count check for importpubkey. (Kristaps Kaupe)
cbd2f70 expose CBlockIndex::nTx in getblock(header) (Gregory Sanders)
ce8aa54 Add Windows shutdown handler (Chun Kuan Lee)
18b0c69 Bugfix: Include <memory> for std::unique_ptr (Luke Dashjr)

Pull request description:

  Backports:
  * #12859 Bugfix: Include <memory> for std::unique_ptr
  * #13131 Add Windows shutdown handler
  * #13451 rpc: expose CBlockIndex::nTx in getblock(header)
  * #13507 RPC: Fix parameter count check for importpubkey
  * #13544 depends: Update Qt download url

  to the 0.16 branch.

Tree-SHA512: eeaec52d001d5c81e67dda3a2d3fee7a9445e569366e597b18e81d802c1b7f89e545afd53d094740c37c1714050304979398b9860144454d3a5cb5abc9e9eaca
@luke-jr luke-jr mentioned this pull request Jul 13, 2018
Merged
HashUnlimited pushed a commit to chaincoin/chaincoin that referenced this pull request Jan 11, 2019
@luke-jr
Bugfix: Include <memory> for std::unique_ptr
6eff73e 
GitHub-Pull: bitcoin#12859
Rebased-From: a5bca13
@AkioNak AkioNak mentioned this pull request Jan 28, 2019
Merged
@PastaPastaPasta PastaPastaPasta mentioned this pull request Apr 7, 2020
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@randolf randolf randolf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

0.16.2

Development

Successfully merging this pull request may close these issues.

7 participants

@luke-jr @randolf @promag @sipa @practicalswift @fanquake @laanwj