doc: Revert to previous header include policy#12960
doc: Revert to previous header include policy#12960maflcko wants to merge 1 commit intobitcoin:masterfrom
Conversation
This partially reverts commit fad0fc3.
|
Can be reviewed by checking out the commit and running: |
|
ACK fa548e7 |
|
@ryanofsky (responding to your comment in #12933) As I mentioned, the ability to use
|
|
To get specific, I guess the immediate question is whether to keep the sentence:
As Marco pointed out, since it says "does not need to" instead of "shouldn't", this isn't actually incompatible with iwyu like I originally thought in the other issue, so I wouldn't object to it anymore. If there is going to be a bigger rewrite, I would like to see something like:
Admittedly, it is a little awkward right now to use iwyu with bitcoin, though I regularly do, and I previously posted instructions at #11878 (comment). It might be possible to add some build system support that would make iwyu easier to run, but I'd have to look into that. |
|
Can we please not spend so much time on this :/ The back and forth on this, merging and reverting, why is this (which is pretty much just a style issue) suddenly such a contended topic. |
It was noted in #12933 that the change to the header include policy was controversial and not agreed upon.
This reverts the guideline to its initial state.