Print to console by default when not run with -daemon by practicalswift · Pull Request #13004 · bitcoin/bitcoin

practicalswift · 2018-04-17T08:03:39Z

Cherry-picked ef6fa1c from the "up for grabs" PR: "Smarter default behavior for -printtoconsole" (#12689).

See previous review in #12689.

Printing to the debug log file can be disabled with -nodebulogfile

fanquake · 2018-04-17T08:08:34Z

@ryanofsky Could you re-review here.

practicalswift · 2018-04-17T08:13:52Z

Previous utACK:ers @meshcollider and @jnewbery might want to take a look at this one too? :-)

instagibbs · 2018-04-17T14:04:43Z

concept ACK

laanwj · 2018-04-17T14:56:00Z

src/init.cpp

-    }
-
    if (fPrintToDebugLog) {
+        if (gArgs.GetBoolArg("-shrinkdebugfile", logCategories == BCLog::NONE)) {


Whoa - good catch to move this inside the if (fPrintToDebugLog)

laanwj · 2018-04-17T15:00:08Z

Thanks for reviving this, tested ACK 6a3b0d3:

src/bitcoind -regtest works as expected, now prints logging output
src/bitcoind -regtest -noprinttoconsole successfully silences logging output
src/bitcoind -regtest -daemon successfully silences logging output

6a3b0d3 Print to console by default when not run with -daemon (Evan Klitzke) Pull request description: Cherry-picked ef6fa1c from the "up for grabs" PR: "Smarter default behavior for -printtoconsole" (#12689). See previous review in #12689. Tree-SHA512: 8923a89b9c8973286d53e960d3c464b1cd026cd5a5911ba62f9f972c83684417dc4004101815dfe987fc1e1baaec1fdd90748a0866bb5548e974d77b3135d43b

maflcko · 2018-04-17T15:17:38Z

test/functional/feature_logging.py

        self.setup_clean_chain = True

+    def relative_log_path(self, name):
+        return os.path.join(self.nodes[0].datadir, "regtest", name)


nit: IIRC datadir is absolute, so the relative in the method name is confusing.

maflcko · 2018-04-17T15:20:43Z

test/functional/feature_logging.py


+        # check that -nodebuglogfile disables logging
+        self.stop_node(0)
+        os.unlink(default_log_path)


Nit: Could use the identical and more clear "remove", since unlink seems to be some unix specific thing, but we also run the tests on windows.

maflcko · 2018-04-17T15:21:48Z

utACK 6a3b0d3. Some naming nits in tests.

jimpo · 2018-04-17T17:12:17Z

src/init.cpp

+    // Add newlines to the logfile to distinguish this execution from the last
+    // one; called before console logging is set up, so this is only sent to
+    // debug.log.
+    LogPrintf("\n\n\n\n\n");


Hmm, won't it print these newlines even if fPrintToDebugLog ends up being false?

aee80b0 qt: Don't log to console by default (Wladimir J. van der Laan) Pull request description: Default `-printtoconsole` to false for the GUI. GUI programs should not print to the console unnecessarily. For example, when launched by the window manager, the output might end up in the X session log file, resulting in duplicate logging. On Windows, it is pointless as well because bitcoin-qt isn't a console application. This same mechanism is used to set `-server` to true by default for bitcoind: https://github.com/bitcoin/bitcoin/blob/master/src/bitcoind.cpp#L116 (fixes #13004) Tree-SHA512: 24ae460d9d97130a063f7bf7fa6da1e6cc46643a94ea0827aa64d0f4a80647e5e7394695b24ea0f49a147a1fa07329659d224f04511fc24b97a9869d1c29b890

It's overly noisy, and not useful to have the bitcoin nodes log to stdout in the functional tests. In case of troubleshooting the `debug.log` files can be inspected. This was the behavior before bitcoin#13004.

bitcoin#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help. This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log. At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.

…debuglogfile (satwo) 5e362c0 Fix command line help for -printtoconsole and -debuglogfile (Samuel B. Atwood) Pull request description: This is a rebased version of #13589 with the changes to the 0.16.x release notes removed. > #13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help. > This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log. > At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR. Tree-SHA512: 7461d59a1864039d5a9dfcce765a1169df882f51a4ca50a6066416c0803821cd821be07be534e0bd57f0a22c0b45adb881a93abbe91962bc37d2d228f35ee712

…gfile changes 801cb30 doc: Add release notes for -printtoconsole and -debuglogfile changes (Samuel B. Atwood) Pull request description: This adds release notes relevant to the changes in #13004 and documented in command line help in #13614. Tree-SHA512: ff320415afa9be1ace37ebf0a69ee5a7e6d4167465bc41111be062a556da9b8accfc39553fac610e68521c7ab2095126ace4f012a32f5e9f37cbec39cfa74b04

bitcoin#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help. This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log. At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.

This adds release notes relevant to the changes in bitcoin#13004 and documented in command line help in bitcoin#13614

bitcoin#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help. This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log. At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.

This adds release notes relevant to the changes in bitcoin#13004 and documented in command line help in bitcoin#13614

…e and -debuglogfile (satwo) 5e362c0 Fix command line help for -printtoconsole and -debuglogfile (Samuel B. Atwood) Pull request description: This is a rebased version of bitcoin#13589 with the changes to the 0.16.x release notes removed. > bitcoin#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help. > This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log. > At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR. Tree-SHA512: 7461d59a1864039d5a9dfcce765a1169df882f51a4ca50a6066416c0803821cd821be07be534e0bd57f0a22c0b45adb881a93abbe91962bc37d2d228f35ee712

aee80b0 qt: Don't log to console by default (Wladimir J. van der Laan) Pull request description: Default `-printtoconsole` to false for the GUI. GUI programs should not print to the console unnecessarily. For example, when launched by the window manager, the output might end up in the X session log file, resulting in duplicate logging. On Windows, it is pointless as well because bitcoin-qt isn't a console application. This same mechanism is used to set `-server` to true by default for bitcoind: https://github.com/bitcoin/bitcoin/blob/master/src/bitcoind.cpp#L116 (fixes bitcoin#13004) Tree-SHA512: 24ae460d9d97130a063f7bf7fa6da1e6cc46643a94ea0827aa64d0f4a80647e5e7394695b24ea0f49a147a1fa07329659d224f04511fc24b97a9869d1c29b890

…aemon 6a3b0d3 Print to console by default when not run with -daemon (Evan Klitzke) Pull request description: Cherry-picked ef6fa1c from the "up for grabs" PR: "Smarter default behavior for -printtoconsole" (bitcoin#12689). See previous review in bitcoin#12689. Tree-SHA512: 8923a89b9c8973286d53e960d3c464b1cd026cd5a5911ba62f9f972c83684417dc4004101815dfe987fc1e1baaec1fdd90748a0866bb5548e974d77b3135d43b

aee80b0 qt: Don't log to console by default (Wladimir J. van der Laan) Pull request description: Default `-printtoconsole` to false for the GUI. GUI programs should not print to the console unnecessarily. For example, when launched by the window manager, the output might end up in the X session log file, resulting in duplicate logging. On Windows, it is pointless as well because bitcoin-qt isn't a console application. This same mechanism is used to set `-server` to true by default for bitcoind: https://github.com/bitcoin/bitcoin/blob/master/src/bitcoind.cpp#L116 (fixes bitcoin#13004) Tree-SHA512: 24ae460d9d97130a063f7bf7fa6da1e6cc46643a94ea0827aa64d0f4a80647e5e7394695b24ea0f49a147a1fa07329659d224f04511fc24b97a9869d1c29b890

…e and -debuglogfile (satwo) 5e362c0 Fix command line help for -printtoconsole and -debuglogfile (Samuel B. Atwood) Pull request description: This is a rebased version of bitcoin#13589 with the changes to the 0.16.x release notes removed. > bitcoin#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help. > This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log. > At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR. Tree-SHA512: 7461d59a1864039d5a9dfcce765a1169df882f51a4ca50a6066416c0803821cd821be07be534e0bd57f0a22c0b45adb881a93abbe91962bc37d2d228f35ee712

…aemon 6a3b0d3 Print to console by default when not run with -daemon (Evan Klitzke) Pull request description: Cherry-picked ef6fa1c from the "up for grabs" PR: "Smarter default behavior for -printtoconsole" (bitcoin#12689). See previous review in bitcoin#12689. Tree-SHA512: 8923a89b9c8973286d53e960d3c464b1cd026cd5a5911ba62f9f972c83684417dc4004101815dfe987fc1e1baaec1fdd90748a0866bb5548e974d77b3135d43b

Print to console by default when not run with -daemon

6a3b0d3

Printing to the debug log file can be disabled with -nodebulogfile

fanquake added the Utils/log/libs label Apr 17, 2018

laanwj reviewed Apr 17, 2018

View reviewed changes

laanwj merged commit 6a3b0d3 into bitcoin:master Apr 17, 2018

maflcko reviewed Apr 17, 2018

View reviewed changes

jimpo reviewed Apr 17, 2018

View reviewed changes

Bushstar mentioned this pull request Apr 18, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#299

Merged

laanwj mentioned this pull request Apr 23, 2018

qt: Don't log to console by default #13055

Merged

laanwj mentioned this pull request Apr 25, 2018

test: Don't log to stdout in functional tests #13071

Closed

Sjors mentioned this pull request Jun 28, 2018

bitcoind on macOS stopped logging to STDOUT by default since 0.16.1 #13520

Closed

ghost mentioned this pull request Jul 2, 2018

Fix command line help for -printtoconsole and -debuglogfile #13589

Closed

fanquake mentioned this pull request Jul 8, 2018

doc: Update command line help for -printtoconsole and -debuglogfile (satwo) #13614

Merged

ghost mentioned this pull request Jul 10, 2018

doc: Add release notes for -printtoconsole and -debuglogfile changes #13625

Merged

sipa mentioned this pull request Aug 9, 2018

Bitcoind no longer outputs logs to stdout #13929

Closed

HashUnlimited mentioned this pull request Sep 11, 2018

Fix command line help for -printtoconsole and -debuglogfile chaincoin/chaincoin#492

Merged

HashUnlimited mentioned this pull request Sep 11, 2018

doc: Add release notes for -printtoconsole and -debuglogfile changes chaincoin/chaincoin#541

Merged

jfhk pushed a commit to jfhk/bitcoin that referenced this pull request Nov 14, 2018

doc: Add release notes for -printtoconsole and -debuglogfile changes

a000ec1

This adds release notes relevant to the changes in bitcoin#13004 and documented in command line help in bitcoin#13614

practicalswift deleted the printtoconsole branch April 10, 2021 19:34

xdustinface pushed a commit to xdustinface/dash that referenced this pull request Apr 14, 2021

More of bitcoin#13004

e444783

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print to console by default when not run with -daemon#13004

Print to console by default when not run with -daemon#13004
laanwj merged 1 commit intobitcoin:masterfrom
practicalswift:printtoconsole

practicalswift commented Apr 17, 2018

Uh oh!

fanquake commented Apr 17, 2018

Uh oh!

practicalswift commented Apr 17, 2018

Uh oh!

instagibbs commented Apr 17, 2018

Uh oh!

laanwj Apr 17, 2018

Uh oh!

laanwj commented Apr 17, 2018

Uh oh!

maflcko Apr 17, 2018

Uh oh!

maflcko Apr 17, 2018

Uh oh!

maflcko commented Apr 17, 2018

Uh oh!

jimpo Apr 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

practicalswift commented Apr 17, 2018

Uh oh!

fanquake commented Apr 17, 2018

Uh oh!

practicalswift commented Apr 17, 2018

Uh oh!

instagibbs commented Apr 17, 2018

Uh oh!

laanwj Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

laanwj commented Apr 17, 2018

Uh oh!

maflcko Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

maflcko Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

maflcko commented Apr 17, 2018

Uh oh!

jimpo Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants