Merged
Conversation
The output would produce arbitrary number of decimal points, sometimes resulting in 9 decimals: AssertionError: Fee of 0.00000415 BTC too low! (Should be 0.000006175 BTC) The above looks like the expected fee is 6175 sats when in reality it's 618. Github-Pull: bitcoin#12486 Rebased-From: 42e1b5d
Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180 Github-Pull: bitcoin#12545 Rebased-From: 0eb84f3
Github-Pull: bitcoin#12553 Rebased-From: 81b0822
rpc_net.py would intermittently fail on Travis, probably due to assuming that two consecutive RPC calls were atomic. Fix this by only testing that amounts are bounded above and below rather than equal. Github-Pull: bitcoin#12804 Rebased-From: 5a67c05
Github-Pull: bitcoin#12843 Rebased-From: 63048ec
Github-Pull: bitcoin#12904 Rebased-From: e36a0c0
Github-Pull: bitcoin#12638 Rebased-From: fa23105
If a cookie file exists in a datadir prior to node startup, it must have been leftover from a prior unclean shutdown. As bitcoind will overwrite it anyway, delete it before starting up to prevent the test framework from inadvertently trying to connect using stale credentials. Github-Pull: bitcoin#12902 Rebased-From: 75d0e4c
Github-Pull: bitcoin#12475 Rebased-From: fa41d68
Member
|
ACK on commit list. |
Merged
Member
|
ACK |
sdaftuar
approved these changes
Apr 24, 2018
maflcko
pushed a commit
that referenced
this pull request
Apr 24, 2018
41c29f6 qa: Fix python TypeError in script.py (MarcoFalke) 7460945 [qa] Delete cookie file before starting node (Suhas Daftuar) 0a76ed2 qa: Cache only chain and wallet for regtest datadir (MarcoFalke) 6c26df0 [qa] Ensure bitcoind processes are cleaned up when tests end (Suhas Daftuar) df38b13 [tests] Test starting bitcoind with -h and -version (John Newbery) 4bdb0ce [tests] Fix intermittent rpc_net.py failure. (John Newbery) 0e98f96 test: Use wait_until in tests where time was used for polling (Ben Woosley) 1286f3e test: Use wait_until to ensure ping goes out (Ben Woosley) cfebd40 [test] Round target fee to 8 decimals in assert_fee_amount (Karl-Johan Alm) Pull request description: Similar to #12967 this contains all relevant bugfixes and improvements to the functional test suite. I didn't include fixes to make the tests run on Windows, since that is still an ongoing effort and doesn't seem worth to backport. As all of these are clean cherry-picks, I suggest reviewers redo the cherry-picks to get the same branch and then run the extended test suite. Tree-SHA512: 70e1bc28d5572f93796f1ac4d97d77e8146869c15dcc1e3b65a730fa2641283050f769cefd9791d800c758e0a92f11fd55ed0797ccec87b897c7e701d0187f34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #12967 this contains all relevant bugfixes and improvements to the functional test suite.
I didn't include fixes to make the tests run on Windows, since that is still an ongoing effort and doesn't seem worth to backport.
As all of these are clean cherry-picks, I suggest reviewers redo the cherry-picks to get the same branch and then run the extended test suite.