[tests] Remove accounts from wallet_importprunedfunds.py#13138
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jul 14, 2018
Merged
[tests] Remove accounts from wallet_importprunedfunds.py#13138maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
jnewbery
changed the title
Member
|
@jnewbery Mind doing a rebase on master, since the last travis run (https://travis-ci.org/bitcoin/bitcoin/builds/373612454) was about two months ago. |
jnewbery
force-pushed
the
remove_account_wallet_importprunedfunds
branch
from
5268a10 to
38040c3
Compare
Contributor
Author
|
Rebased on master. I can no longer repro the OOM locally (tried running the test 100 times), and Travis passes. @MarcoFalke - can you try running this locally? I'm removing the [Do not merge] tag, since if this runs reliably it's ready for merge. |
jnewbery
changed the title
Member
Member
|
Concept ACK 38040c3 Going to take a closer look later |
Member
|
utACK 38040c3 |
maflcko
pushed a commit
that referenced
this pull request
Jul 14, 2018
38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery) Pull request description: This was split from #13075 to not block review/merge of that PR. Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 6, 2019
Summary: 38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery) Pull request description: This was split from #13075 to not block review/merge of that PR. Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab Backport of Core PR13138 bitcoin/bitcoin#13138 Depends on D4540 Test Plan: test_runner.py wallet_importprunedfunds Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D4541
11 tasks
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 27, 2020
…funds.py 38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery) Pull request description: This was split from bitcoin#13075 to not block review/merge of that PR. Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 28, 2021
…funds.py 38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery) Pull request description: This was split from bitcoin#13075 to not block review/merge of that PR. Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was split from #13075 to not block review/merge of that PR.