GUI: fix translation generation for UI options and a few other strings in the...#1322
GUI: fix translation generation for UI options and a few other strings in the...#1322Diapolo wants to merge 1 commit intobitcoin:masterfrom Diapolo:fix_translation_Ui_Options
Conversation
…the HelpMessageBox class, as tr() does not work that early in the code
|
This is not the right way to solve it. I moved the ui-specific stuff out of As this is a ui-only problem, please solve this without changes to the core. Note that _ is defined in ui code, you can call it from there. However, it |
|
tr() did not work, please try it. Even if the fix is not what it needs to be, there is a problem. And tr() vs. _() is for sure a difference, because _() shows up in bitcoinstrings.cpp, while this is not true for tr(). |
|
Strings that are defined in src/qt/bitcoin.cpp should not show up in |
|
Did you try to verify the problem? Before we start a discussion battle I would like to know if I found a bug or did something wrong in my local build ;). Try to change tr("Usage:") into something stupid like tr("Pig:"), what I say is that even after a translation the word "Usage:" is used in it's untranslated form. |
|
I think I know why tr doesn't work in our new class: Q_OBJECT is missing. |
|
I certainly did believe you that something is wrong, and wasn't trying to start a discussion battle. But I first wanted to know why it went wrong, instead of trying to work around it. #1324 fixes this. |
|
It's all fine, I seem to have missunderstood what you were trying to say :). I'm glad it's fixed! |
CService fails to initialize correctly on Windows for whatever reason, replacing this functionality with SplitHostPort call.
…cpp cleaning 80753f9 [Cleanup] Remove multiple calls to chainActive in main functions (random-zebra) 3ddeeed [zPIV][Cleanup] Remove mapZerocoinspends (random-zebra) 334b760 [zPIV][Cleanup] remove ContextualCheckZerocoinMint (random-zebra) 39116fb [zPIV][Cleanup] Remove non-public zerocoin spend checks in ATMP (random-zebra) Pull request description: This removes unneeded checks in AcceptToMemoryPool and cleans up main.cpp file ACKs for top commit: Fuzzbawls: ACK 80753f9 furszy: Full sync, ACK 80753f9. Tree-SHA512: ee6b56a2e5db188e7bfc83649019a0ccd47dee0eaea3cfbd8c628ca10a0b0b89465c8c01c9d39535aba4374741291c021852d84ab1b5969ef4cf90fb30f257d8
…in mint checks 803f5dd [Trivial] Single method ScriptSigToSerializedSpend (random-zebra) dc0cc41 [Cleanup] Remove CoinSpend dependancy from CTxIn (random-zebra) 935c99c [Cleanup] Remove unused IsSerialKnown function in zpivchain.* (random-zebra) 1493473 [Cleanup] Remove CheckZerocoinMint main function (random-zebra) Pull request description: This is built on top of - [x] bitcoin#1322 This removes `CheckZerocoinMint` (mints are disabled since block 1,686,229 and we can rely on checkpoints during IBD). Also does some minor cleanup in zpivmodule/zpivchain ACKs for top commit: furszy: Looking good, utACK 803f5dd Fuzzbawls: ACK 803f5dd Tree-SHA512: 5fe1c835ff95330be32561ca12e1c29cb46404be68f4ca7caf2e3e5c51ff9364ead8bc781284e3c49dc0bd5efac28d3f24a901e92e3cc0d4b7af17b2146eaf50
2 participants
... HelpMessageBox class, as tr() does not work that early in the code
I was wondering, why for example the translation for "Usage:" did not work, althoug it was in the (in my example) de language file. I found out that using the _() function does it's job and so I added 2 new functions in init.cpp to be able to get the strings translated and the translations used.
This needs an additional bitcoinstrings.cpp update!