Update gitian-build.sh for docker#13368
Conversation
|
Concept ACK, thanks for working on this. |
contrib/gitian-build.sh
Outdated
There was a problem hiding this comment.
Are you sure that this digest will stay the same? They update the image very often. https://hub.docker.com/r/library/ubuntu/tags/
Edit: That make sure that docker always pull the same image base.
There was a problem hiding this comment.
Is there any way to verify this hash?
I tried to build the image from scratch using https://github.com/tianon/docker-brew-ubuntu-core/blob/master/update.sh but it would give a different hash each run...
There was a problem hiding this comment.
@achow101 Is this hash even supposed to be deterministic or does it just serve the purpose of an unique identifier?
There was a problem hiding this comment.
I'm not sure.. I think it may just serve as a unique identifier.
There was a problem hiding this comment.
In that case I'd prefer the second commit to be dropped. I believe for our purposes it suffices to use the "ubuntu:bionic" as a unique identifier.
|
utACK 86967b2 |
|
Tested ACK 4b5b2c9c398237645450e25fe7188a3e0422e94a |
|
Concept ACK, should this go in before #13623? |
|
I dropped the second commit that used gitian image hashes. |
86967b2 Add option to use docker for gitian-build.sh (Andrew Chow) Pull request description: Updates gitian-build.sh script for the docker virtualization method recently added to gitian-builder. Second commit depends on devrandom/gitian-builder#185 Tree-SHA512: 0fa50b6c1be35a7a39f4a82816369637d3d0082922ac9876b80ae8156c795dec0ff34ad384b5348777042df8ddb6a72bbaeddd7002ef80557b10e2acf46632aa
|
Do this actually work with latest version of gitian-builder? I always get a error message |
|
@ken2812221 It works for me. Maybe you need to run it as root (with |
5 participants
Updates gitian-build.sh script for the docker virtualization method recently added to gitian-builder.
Second commit depends on devrandom/gitian-builder#185