Merged
Conversation
Contributor
|
Timing the operation is useful, but there is not much use in reporting the other information again. Just follow wallet.dat's lead and say "flushed foo.dat NN ms" |
Contributor
Author
|
is this better? |
|
@jgarzik I think it would be nice to define a standard format for these time-measuring log entries all over the code. |
jgarzik
pushed a commit
that referenced
this pull request
May 18, 2012
Report how long DBFlush took.
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
Report how long DBFlush took.
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
multithreaded transaction admission
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
…hainparams 47f552d [Cleanup] Remove MineBlocksOnDemand function in chainparams (random-zebra) Pull request description: The only network where fMineBlocksOnDemand is true is regtest (unittest network was removed in bitcoin#1330 ) Just use IsRegTestNet function. ACKs for top commit: furszy: utACK 47f552d Tree-SHA512: 95bc644532675a55098e1836286b15c462221879b25018c0f89c3c9bcd626556b928d65641996ff41aad34460c2f1940390479575e4845aa43e742409832c1a0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report how long DBFlush() takes.
Tested for over 6 weeks.