Remove boost::program_options dependency by ken2812221 · Pull Request #13482 · bitcoin/bitcoin

ken2812221 · 2018-06-16T04:25:16Z

Concept from #12744, but without parsing negated options.

qmma70 · 2018-06-16T18:16:55Z

src/util.h

Is there a reason for this method to start with a lower case letter while all other start with upper case letters?

No reason. So make it uppercase.

qmma70 · 2018-06-16T18:19:24Z

src/util.cpp

Use cbegin() and cend() please.

I made it range-based

qmma70 · 2018-06-16T18:21:01Z

src/util.cpp

Minor: can use std::make_pair(name, value) for simplicity.

emplace_back is more simple.

qmma70 · 2018-06-16T21:07:48Z

I'm utAck on this. Nicely done.

This could have also been implemented with regex, but the pattern is simple enough that the logic is easily understandable.

Empact · 2018-06-17T21:12:21Z

Concept ACK - maybe include the tests from #12744?

ken2812221 · 2018-06-18T01:19:07Z

@Empact Those tests have been added by #12713

ken2812221 · 2018-06-18T18:05:04Z

Current on master, if there are some options in the config file without =, they would cause an exception. In this PR, I simply ignore them, or should I also throw an exception?

DrahtBot · 2018-06-19T22:40:34Z

Note to reviewers: This pull request conflicts with the following ones:

travis: Switch back to trusty for now #13562 (travis: Switch back to trusty for now by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

jezzalladmins

Run

DrahtBot · 2018-06-24T14:18:55Z

Needs rebase

maflcko · 2018-06-24T14:21:27Z

Update doc/build-unix.md as well?

ken2812221 · 2018-06-25T02:52:35Z

@MarcoFalke Sure

sipa · 2018-06-27T00:25:51Z

src/util.cpp

Coding style nit: use braces whenever indenting.

sipa · 2018-06-27T00:25:59Z

src/util.cpp

sipa · 2018-06-27T00:27:15Z

src/util.cpp

Maybe introduce a static constant for this set of trimmable characters?

I'm not sure this is what you want.

sipa · 2018-07-18T02:02:25Z

src/util.cpp

This can just be a static function; it doesn't need to be a method of ArgsManager.

sipa · 2018-07-18T02:50:45Z

Why close?

ken2812221 · 2018-07-18T02:51:08Z

Sorry, misclicked

sipa · 2018-07-19T21:50:36Z

utACK f447a0a

laanwj · 2018-07-20T14:30:21Z

build-aux/m4/ax_boost_program_options.m4

@@ -1,108 +0,0 @@
-# ============================================================================


I like this file-bloodbath.

laanwj · 2018-07-20T14:40:58Z

+42 −123 even though this is removing an external dependency, if that isn't a clear indication that this should be done I don't know what is.
utACK f447a0a

f447a0a Remove program options from build system (Chun Kuan Lee) 11588c6 Replace boost program_options (Chun Kuan Lee) Pull request description: Concept from #12744, but without parsing negated options. Tree-SHA512: 7f418744bb8934e313d77a5f162633746ef5d043de802b9c9cd9f7c1842e7e566eb5f171cd9e2cc13317281b2449c6fbd553fa4f09b837e6af2f5d2b2aabdca2

0385109 Add test for rpcpassword hash error (MeshCollider) 13fe258 Error if rpcpassword in conf contains a hash character (MeshCollider) Pull request description: Fixes #13143 now #13482 was merged Tree-SHA512: e7d00c8df1657f6b8d0eee1e06b9ce2b1b0a2de487377699382c1b057836e1571dac313ca878b5877c862f0461ba789a50b239d2a9f34accd8a6321f126e3d2a

be6563a Remove program options from build systems (Fuzzbawls) 025b8c2 Replace boost program_options (Fuzzbawls) Pull request description: Follow-up to #2324 which backports bitcoin#13482 This removes the dependency on Boost's program_options module ACKs for top commit: random-zebra: utACK be6563a furszy: utACK be6563a and merging Tree-SHA512: 6b1550e20c0bb6b3ec16659b181724cf72f02c7c00b584bdfabe06b77feeea249910e073393775f47499dfa0a7fb9137d952e8ad9f78df0ff03cc9b5a8e1c96b

f447a0a Remove program options from build system (Chun Kuan Lee) 11588c6 Replace boost program_options (Chun Kuan Lee) Pull request description: Concept from bitcoin#12744, but without parsing negated options. Tree-SHA512: 7f418744bb8934e313d77a5f162633746ef5d043de802b9c9cd9f7c1842e7e566eb5f171cd9e2cc13317281b2449c6fbd553fa4f09b837e6af2f5d2b2aabdca2

0385109 Add test for rpcpassword hash error (MeshCollider) 13fe258 Error if rpcpassword in conf contains a hash character (MeshCollider) Pull request description: Fixes bitcoin#13143 now bitcoin#13482 was merged Tree-SHA512: e7d00c8df1657f6b8d0eee1e06b9ce2b1b0a2de487377699382c1b057836e1571dac313ca878b5877c862f0461ba789a50b239d2a9f34accd8a6321f126e3d2a

fanquake added the Refactoring label Jun 16, 2018

qmma70 reviewed Jun 16, 2018

View reviewed changes

DrahtBot mentioned this pull request Jun 19, 2018

gui: Drop qt4 support #13458

Merged

jezzalladmins suggested changes Jun 22, 2018

View reviewed changes

DrahtBot added the Needs rebase label Jun 24, 2018

DrahtBot removed the Needs rebase label Jun 25, 2018

sipa reviewed Jun 27, 2018

View reviewed changes

DrahtBot mentioned this pull request Jun 30, 2018

travis: Switch back to trusty for now #13562

Closed

sipa reviewed Jul 18, 2018

View reviewed changes

src/util.cpp Outdated

Copy link

Member

sipa Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be a static function; it doesn't need to be a method of ArgsManager.

ken2812221 closed this Jul 18, 2018

ken2812221 added 2 commits July 18, 2018 02:48

Replace boost program_options

11588c6

Remove program options from build system

f447a0a

ken2812221 reopened this Jul 18, 2018

fanquake added this to the 0.17.0 milestone Jul 18, 2018

laanwj reviewed Jul 20, 2018

View reviewed changes

laanwj merged commit f447a0a into bitcoin:master Jul 20, 2018

ken2812221 deleted the program_options branch July 20, 2018 14:51

Bushstar mentioned this pull request Jul 24, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#357

Merged

meshcollider mentioned this pull request Oct 16, 2018

Error if # is used in rpcpassword in conf #14494

Merged

Fuzzbawls mentioned this pull request Apr 27, 2021

[Util] Remove boost program_options dependency PIVX-Project/PIVX#2343

Merged

barton2526 mentioned this pull request Aug 13, 2021

depends: Remove boost::program_options dependency gridcoin-community/Gridcoin-Research#2277

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

		@@ -1,108 +0,0 @@
		# ============================================================================

Conversation

ken2812221 commented Jun 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ken2812221 Jun 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ken2812221 Jun 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qmma70 commented Jun 16, 2018

Uh oh!

Empact commented Jun 17, 2018

Uh oh!

ken2812221 commented Jun 18, 2018

Uh oh!

ken2812221 commented Jun 18, 2018

Uh oh!

DrahtBot commented Jun 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jezzalladmins left a comment

Choose a reason for hiding this comment

Uh oh!

DrahtBot commented Jun 24, 2018

Uh oh!

maflcko commented Jun 24, 2018

Uh oh!

ken2812221 commented Jun 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sipa commented Jul 18, 2018

Uh oh!

ken2812221 commented Jul 18, 2018

Uh oh!

sipa commented Jul 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj commented Jul 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ken2812221 Jun 16, 2018 •

edited

Loading

ken2812221 Jun 16, 2018 •

edited

Loading

DrahtBot commented Jun 19, 2018 •

edited

Loading