bench: Add missing pow.h header#13530
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jun 24, 2018
Merged
Conversation
Fix a build error introduced in bitcoin#13219. ``` .../bitcoin/src/bench/block_assemble.cpp:42:13:error: use of undeclared identifier 'CheckProofOfWork' while (!CheckProofOfWork(block->GetHash(), block->nBits, Params().GetConsensus())) { ```
Member
|
ACK cec84c2, build is broken without it. |
laanwj
added a commit
that referenced
this pull request
Jun 24, 2018
cec84c2 bench: Add missing pow.h header (Wladimir J. van der Laan) Pull request description: Fix a build error introduced in #13219. ``` .../bitcoin/src/bench/block_assemble.cpp:42:13:error: use of undeclared identifier 'CheckProofOfWork' while (!CheckProofOfWork(block->GetHash(), block->nBits, Params().GetConsensus())) { ``` Tree-SHA512: 6ef78011fd7bd82859530b2676ba533b15db6c753cb84a1286b7e26ed6f3d2064769e42900b2479fe6c460411f742e2baed716db5eac06d3bc455e08c290a087
Member
|
ACK, seems this was a silent merge conflict with 5b35b92 |
Member
|
Also my lack of using iwyu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a build error introduced in #13219.