GUI: Peer table: Visualize inbound/outbound state for every row · Pull Request #13537 · bitcoin/bitcoin

ghost · 2018-06-25T16:26:34Z

The address in the network peer table is prefixed with an up-arrow symbolizing an outbound connection, or an down-array symbolizing an inbound connection. See screenshot.

The user has an easy visual confirmation about the connection direction state. I really like it :)
Impact to columns sorting is grouping by inbound/outbound first, which in my opinion is an advantage, too.

promag

Concept ACK.

promag · 2018-06-26T14:29:43Z

src/qt/peertablemodel.cpp

Prefer:

address_output_prefix = rec->nodeStats.fInbound ? "↓ " : "↑ ";

promag · 2018-06-26T14:33:26Z

src/qt/peertablemodel.cpp

Could inline like:

return QString(rec->nodeStats.fInbound ? "↓ " : "↑ ") + QString::fromStdString(rec->nodeStats.addrName);

and remove declaration above.

ghost · 2018-06-26T17:43:36Z

@promag Thanks, cleaner and shorter code. Rebased and squashed.

jonasschnelli · 2018-06-26T19:24:13Z

src/qt/peertablemodel.cpp

        case Address:
-            return QString::fromStdString(rec->nodeStats.addrName);
+            // prepend to peer address down-arrow symbol for inbound connection and up-arrow for outbound connection
+            return QString(rec->nodeStats.fInbound ? "↓ " : "↑ ") + QString::fromStdString(rec->nodeStats.addrName);


Does those unicode char (86 93 and 86 91) work on all supported platforms (especially older windows version)?
Would using an Icon make more sense?

Could You define 'older windows version'?

Windows 7 or later is what we are currently supporting.

I can not test for Windows, since I do not have any Windows. Maybe someone with Windows testing capabilities can apply this one-liner and check?

These characters have been in unicode since time immemorial [Unicode 1.1.0 (June, 1993], I wouldn't be afraid of them not being supported.

jonasschnelli · 2018-06-26T19:24:39Z

Nice and small change. Concept ACK

jb55

utACK 4132ad3

jonasschnelli · 2018-06-29T16:19:33Z

utACK 4132ad3

laanwj · 2018-06-29T16:20:15Z

The address in the network peer table is prefixed with an up-arrow symbolizing an outbound connection, or an down-array symbolizing an inbound connection. See screenshot.

Thank you for doing it this way, instead of adding another column.
utACK 4132ad3

fanquake · 2018-07-01T03:36:15Z

tACK 4132ad3

macOS 10.13.5

master:

4132ad3:

Windows 10

4132ad3:

The symbol could be a bit hard to make out on Windows, but Windows really needs an overhaul in terms of font/sizing anyways, so I don't think that should block anything here.

…very row 4132ad3 Show symbol for inbound/outbound in peer table (wodry) Pull request description: Fixes #13483 The address in the network peer table is prefixed with an up-arrow symbolizing an outbound connection, or an down-array symbolizing an inbound connection. See screenshot. The user has an easy visual confirmation about the connection direction state. I really like it :) Impact to columns sorting is grouping by inbound/outbound first, which in my opinion is an advantage, too. ![bildschirmfoto](https://user-images.githubusercontent.com/8447873/41862752-13803eb2-78a5-11e8-9126-a52385f5ec19.png) Tree-SHA512: d355f679d34c3006743c06750be5f36a083c1a8376da8f5f35045fcd9df964153409946fdde5007734f23bd692c91355962dc42df31122cdcf88e4affce8bc0e

Github-Pull: bitcoin#13537 Rebased-From: 4132ad3

…e for every row 4132ad3 Show symbol for inbound/outbound in peer table (wodry) Pull request description: Fixes bitcoin#13483 The address in the network peer table is prefixed with an up-arrow symbolizing an outbound connection, or an down-array symbolizing an inbound connection. See screenshot. The user has an easy visual confirmation about the connection direction state. I really like it :) Impact to columns sorting is grouping by inbound/outbound first, which in my opinion is an advantage, too. ![bildschirmfoto](https://user-images.githubusercontent.com/8447873/41862752-13803eb2-78a5-11e8-9126-a52385f5ec19.png) Tree-SHA512: d355f679d34c3006743c06750be5f36a083c1a8376da8f5f35045fcd9df964153409946fdde5007734f23bd692c91355962dc42df31122cdcf88e4affce8bc0e

…r every row Summary: 4132ad3 Show symbol for inbound/outbound in peer table (wodry) Pull request description: Fixes #13483 The address in the network peer table is prefixed with an up-arrow symbolizing an outbound connection, or an down-array symbolizing an inbound connection. See screenshot. The user has an easy visual confirmation about the connection direction state. I really like it :) Impact to columns sorting is grouping by inbound/outbound first, which in my opinion is an advantage, too. ![bildschirmfoto](https://user-images.githubusercontent.com/8447873/41862752-13803eb2-78a5-11e8-9126-a52385f5ec19.png) --- Backport of Core [[bitcoin/bitcoin#13537 | PR13537]] Test Plan: ninja all ./qt/bitcoin-qt -testnet enter "Peers" window and look for arrows Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8543

hebasto · 2021-08-08T10:38:30Z

Impact to columns sorting is grouping by inbound/outbound first, which in my opinion is an advantage, too.

It is removes an option to sort by address, that is wrong.

…e for every row 4132ad3 Show symbol for inbound/outbound in peer table (wodry) Pull request description: Fixes bitcoin#13483 The address in the network peer table is prefixed with an up-arrow symbolizing an outbound connection, or an down-array symbolizing an inbound connection. See screenshot. The user has an easy visual confirmation about the connection direction state. I really like it :) Impact to columns sorting is grouping by inbound/outbound first, which in my opinion is an advantage, too. ![bildschirmfoto](https://user-images.githubusercontent.com/8447873/41862752-13803eb2-78a5-11e8-9126-a52385f5ec19.png) Tree-SHA512: d355f679d34c3006743c06750be5f36a083c1a8376da8f5f35045fcd9df964153409946fdde5007734f23bd692c91355962dc42df31122cdcf88e4affce8bc0e

fanquake added GUI P2P labels Jun 25, 2018

promag reviewed Jun 26, 2018

View reviewed changes

Show symbol for inbound/outbound in peer table

4132ad3

jonasschnelli reviewed Jun 26, 2018

View reviewed changes

jb55 approved these changes Jun 26, 2018

View reviewed changes

jonasschnelli merged commit 4132ad3 into bitcoin:master Jul 1, 2018

ghost deleted the peer-table-show-inbound-outbound-symbol branch July 1, 2018 13:23

Bushstar mentioned this pull request Jul 2, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#351

Merged

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Jul 30, 2018

Show symbol for inbound/outbound in peer table

a6f1df8

Github-Pull: bitcoin#13537 Rebased-From: 4132ad3

ghost mentioned this pull request Jun 27, 2021

Add Direction column to Peers Tab bitcoin-core/gui#317

Merged

hebasto mentioned this pull request Aug 8, 2021

Honor inbound/outbound arrow prefix when sorting peer address column bitcoin-core/gui#400

Closed

hebasto mentioned this pull request Aug 8, 2021

Summary of Direction/Type columns problem and a new suggested trade-off bitcoin-core/gui#401

Closed

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

Conversation

ghost commented Jun 25, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

promag Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

promag Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

ghost commented Jun 26, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasschnelli Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

ghost Jun 26, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fanquake Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

ghost Jun 29, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Jun 26, 2018

Uh oh!

jb55 left a comment

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Jun 29, 2018

Uh oh!

laanwj commented Jun 29, 2018

Uh oh!

fanquake commented Jul 1, 2018

macOS 10.13.5

Windows 10

Uh oh!

hebasto commented Aug 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ghost commented Jun 25, 2018 •

edited by ghost

Loading

ghost commented Jun 26, 2018 •

edited by ghost

Loading

ghost Jun 26, 2018 •

edited by ghost

Loading

ghost Jun 29, 2018 •

edited by ghost

Loading

laanwj Jun 29, 2018 •

edited

Loading