Document assumptions made in PeerLogicValidation::SendMessages(...) and rescanblockchain(...)#13548
Closed
practicalswift wants to merge 2 commits intobitcoin:masterfrom
Closed
Conversation
Contributor
I don't agree, it's obvious because they are used right after the assertions. |
Contributor
Author
|
@promag Yes, but the assertion documents that the dereference without a prior null check is intentional and not just an oversight. That helps static analyzers and human reviewers, don’t you agree? :-) FWIW I’ve seen numerous static analyzers independently flag these specific cases (and the cases covered by the other similar assertion PR:s). I’m not just adding asserts randomly for fun :-) |
Contributor
| No more conflicts as of last run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document assumptions made in
PeerLogicValidation::SendMessages(...)andrescanblockchain(...)via assertions.The fact that
pBestIndex != nullptrandstopBlock != nullptrin these contexts is not immediately obvious. Explicit is better than implicit.