Both Windows builds failed with:

In file included from /home/travis/build/bitcoin/bitcoin/depends/i686-w64-mingw32/share/../include/boost/thread/win32/condition_variable.hpp:9:0,
                 from /home/travis/build/bitcoin/bitcoin/depends/i686-w64-mingw32/share/../include/boost/thread/condition_variable.hpp:14,
                 from ./util.h:35,
                 from ./init.h:11,
                 from init.cpp:10:
/home/travis/build/bitcoin/bitcoin/depends/i686-w64-mingw32/share/../include/boost/thread/win32/thread_primitives.hpp:177:55: warning: conflicts with previous declaration 'void* boost::detail::win32::GetModuleHandleA(const char*)'
                 __declspec(dllimport) void* __stdcall GetModuleHandleA(char const*);
                                                       ^~~~~~~~~~~~~~~~
In file included from /usr/share/mingw-w64/include/windows.h:71:0,
                 from /usr/share/mingw-w64/include/winsock2.h:23,
                 from ./compat.h:39,
                 from ./util.h:17,
                 from ./init.h:11,
                 from init.cpp:10:
init.cpp:1245:5: error: expected identifier before numeric constant
     ERROR = 2,
     ^
init.cpp:1245:5: error: expected '}' before numeric constant
init.cpp:1245:5: error: expected unqualified-id before numeric constant
init.cpp:1246:1: error: expected declaration before '}' token
 };
 ^
make[2]: *** [libbitcoin_server_a-init.o] Error 1
Makefile:5820: recipe for target 'libbitcoin_server_a-init.o' failed

Renamed ERROR to FATAL to avoid windows conflict. Note this was in an enum class so seems Windows is applying an ERROR macro or the like.

utACK 67ed865.

Nice refactor. Personally, I find the enum a bit heavy and think it would be simpler to return a bool and an additional bool fatal_err outparam, but I don't feel too strongly. Check in the false return case could just be

if (fShutdownRequested) {
} else if (success) {
} else if (fReset || fatal_err) {
   return InitError( );
} else {
}

Thanks for the review @jimpo. I see what you mean - switched to a boolean return, and made fReset an out arg as it was already being used to trigger the retry behavior, so now it can be toggled within the function to disable retry. Lmk if you have thoughts on that.

utACK fb28c7f5cf903c0c21f823b2e179a39bd69c9549

Yes, I like this approach more.

Rebased for #13235

Needs rebase for #13577

Rebased for #13577

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #15329 (Fix InitError() and InitWarning() content by hebasto)
• #15218 (validation: Flush state after initial sync by andrewtoth)
• #12980 (Allow quicker shutdowns during LoadBlockIndex() by jonasschnelli)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Switched to using function-try-block. If people aren't into that, maybe we should discourage them in the developer-notes?
https://en.cppreference.com/w/cpp/language/function-try-block

Travis failed with unrelated error, restarted.

Regarding function-try-block I'm -0 if the reasoning is just to save one level of indentation in the function body.

Yeah, on second thought, switched back to regular try/catch. The framing of the function body and the consistent treatment help with the reading of the function IMO.

utACK a2dbe2a.

Rebased for #14437

Appveyor failure looks unrelated

Reworked to minimize git diff --color-moved=dimmed_zebra --color-moved-ws=allow-indentation-change head^. Now is a minimal extraction.

Rebase for #15402

Rebased

Closing as rebasing this is too much a chore. :P