[travis] Don't store debug info if --enable-debug is set#13650
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jul 24, 2018
ken2812221:travis-debug-fix
Merged
[travis] Don't store debug info if --enable-debug is set#13650maflcko merged 1 commit intobitcoin:masterfrom ken2812221:travis-debug-fix
maflcko merged 1 commit intobitcoin:masterfrom
ken2812221:travis-debug-fix
Conversation
Contributor
Author
|
ping @theuni |
Member
|
Doesn't this override the flags completely, so also change optimization etc? (not that it probably matters) |
Member
|
From the Travis log: So it seems it isn't being overridden. |
Member
|
That's weird. It even still passes in |
Contributor
Author
|
Yes, the latter option can override the previous one. |
Contributor
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
On travis the time is back to 10 minutes and the flags are appended https://travis-ci.org/bitcoin/bitcoin/jobs/405944009#L2388 ACK from me |
Member
maflcko
pushed a commit
that referenced
this pull request
Jul 24, 2018
14788fb [travis] Don't store debug info if --enable-debug is set (Chun Kuan Lee) Pull request description: After #12686 merged, ccache store huge size of .o files, simply get rid of those useless debug info. Fixes #13748 Tree-SHA512: fb404e2c7d52cd8266548433955c41683ede062f97c8fb7098a887f164bcde48b60e5e533a0a27c7e095fdd9ef88db018b8689adebb2c0e32c8957828629e346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #12686 merged, ccache store huge size of .o files, simply get rid of those useless debug info.
Fixes #13748