[build] Add risc-v support to gitian by ken2812221 · Pull Request #13665 · bitcoin/bitcoin

ken2812221 · 2018-07-15T04:08:22Z

Based on ~~#13660~~ #13710 , add gitian tarball for RISC-V

laanwj · 2018-07-17T14:26:29Z

ACK but only after we can compile with a compiler that doesn't produce a broken test_bitcoin. If inlining is broken, who knows what other bugs are introduced.
(see #13543 (comment) and following comments)
Maybe Ubuntu will provide a newer version of gcc at some point.

ken2812221 · 2018-07-18T20:16:46Z

@laanwj How about force it to use gcc-8?

laanwj · 2018-07-19T14:09:17Z

Yes, that was what I meant. But how?

ken2812221 · 2018-07-19T15:44:31Z

Just see what I do in the fourth commit.

laanwj · 2018-07-19T16:38:07Z

Didn't know that a package for that was available!
Can someone confirm that the resulting test_bitcoin runs without issues?

Edit: interesting;
I wonder if this is the only way to get the -8 variant to be used.
If there's no update-alternatives incantation to update the symlinks. This would be more convenient for the build guide.

Edit no, apparently the risc-v compiler packages do not provide alternatives

laanwj · 2018-07-19T16:55:51Z

Concept ACK

theuni

Concept ACK, but I don't think it's wise for us to be producing supported binaries for a platform that's still going through teething issues with compilers. Especially since so few people are able to test.

I'm all for it for 0.18, but -1 from me for 0.17.

theuni · 2018-07-19T17:49:39Z

contrib/gitian-descriptors/gitian-linux.yml

I suspect that this will cause more glibc back-compat issues. That's fine, of course, they just need to be accounted for.

I've tested this. make -C src check-symbol is happy about this in gitian build.

theuni · 2018-07-19T17:51:06Z

depends/packages/qt.mk

This shouldn't be needed after #13696 (comment).

This is not my commit, just based on #13696

theuni · 2018-07-19T17:52:38Z

src/compat/glibc_compat.cpp

Is this necessary? We don't have to support much back-compat for riscv, as its glibc support is pretty new anyway.

This might not be necessary. But we should drop --enable-glibc-back-compat flag when building for RISC-V

I think he did this to appease the symbols check, the alternative would be to do a different symbols check per target platform.

I did this so the linker would know what log2f_old is.

laanwj · 2018-07-20T10:05:29Z

I'm all for it for 0.18, but -1 from me for 0.17.

Added appropriate milestone

DrahtBot · 2018-07-22T13:32:51Z

Note to reviewers: This pull request conflicts with the following ones:

[contrib] Support ARM and RISC-V symbol check #13724 ([contrib] Support ARM and RISC-V symbol check by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko · 2018-08-08T16:43:56Z

gitian linux failure:

ERROR: Feature 'system-zlib' was enabled, but the pre-condition 'libs.zlib' failed.

ERROR: Feature 'openssl-linked' was enabled, but the pre-condition '!features.securetransport && libs.openssl' failed.

ERROR: Feature 'xcb' was enabled, but the pre-condition 'libs.xcb' failed.

ERROR: Feature 'system-freetype' was enabled, but the pre-condition 'features.freetype && libs.freetype' failed.

ERROR: Feature 'fontconfig' was enabled, but the pre-condition '!config.win32 && !config.darwin && features.system-freetype && libs.fontconfig' failed.
funcs.mk:242: recipe for target '/home/ubuntu/build/bitcoin/depends/work/build/riscv64-linux-gnu/qt/5.9.6-c69c157d1d9/qtbase/.stamp_configured' failed
make: *** [/home/ubuntu/build/bitcoin/depends/work/build/riscv64-linux-gnu/qt/5.9.6-c69c157d1d9/qtbase/.stamp_configured] Error 3
make: Leaving directory '/home/ubuntu/build/bitcoin/depends'

ken2812221 · 2018-08-08T19:36:25Z

@MarcoFalke Sry, missing one line during rebasing #13710

ken2812221 · 2018-08-09T05:37:07Z

@MarcoFalke @DrahtBot fetch the wrong commit.

laanwj · 2018-08-15T16:20:16Z

What is the reason this is still WIP? would like to merge this early in the 0.18 cycle if possible.
(going to test)

ken2812221 · 2018-08-15T16:31:45Z

@laanwj You can see @DrahtBot 's binary, it exports so many unnecessary symbols

laanwj · 2018-08-16T08:50:51Z

I'm not sure how worried we should be about exporting unnecessary symbols on RISC-V at this point, from what I gather everything is still extremely experimental, there aren't even ready-to-use linux distribution images.

The "don't export unnecessary symbols" check was, at the time, added to avoid collisions between statically-linked and dynamically-linked OpenSSL, back in the day that Qt was still linked dynamically. This is no longer an actual issue.
Now it's only a "nice" sanity and hygiene check, to avoid the overhead of huge unnecessary symbol tables in an executable.

So I don't think that needs to hold back progress, seems like be something that is improved in a later PR, but I'll leave it up to you.

ken2812221 · 2018-08-16T10:52:23Z

@laanwj Thanks for clarification. The export symbol things can be done in future PR. At least I can't solve the problem for now, leave for someone who can work on improving this.

laanwj · 2018-08-16T18:32:01Z

ACK c4aecd1
gitian build result tested on actual hardware (HiFive Unleashed=U540) w/ Fedora release 29 (Rawhide):

# ./test_bitcoin 
Running 303 test cases...
test/scheduler_tests.cpp(141): info: counter2++
test/scheduler_tests.cpp(141): info: counter2++
test/scheduler_tests.cpp(145): info:  == 
test/scheduler_tests.cpp(145): info: i          
*** No errors detected

Also synced the beginning of the chain, I'll keep this node running.

Going to merge this because I want to keep building for RISC-V on the 0.18 branch. If any issues come up we can revert this before the 0.18.0 release.

laanwj · 2018-08-23T05:36:21Z

Also synced the beginning of the chain, I'll keep this node running.

This was successful!
Synchronization of the full chain on the HiFive Unleashed board to a nbd partition took about 2-3 days.
(had to restart at some point as there were problems with the SD card interface or driver, but there were zero issues with bitcoind)

fanquake added the Build system label Jul 15, 2018

fanquake requested a review from laanwj July 16, 2018 02:02

DrahtBot added the Needs rebase label Jul 16, 2018

DrahtBot removed the Needs rebase label Jul 17, 2018

maflcko added the Needs gitian build label Jul 19, 2018

laanwj requested a review from theuni July 19, 2018 16:55

theuni reviewed Jul 19, 2018

View reviewed changes

laanwj added this to the 0.18.0 milestone Jul 20, 2018

DrahtBot removed the Needs gitian build label Jul 21, 2018

This was referenced Jul 22, 2018

Depends: Fix Qt's rcc determinism #13732

Merged

[contrib] Support ARM and RISC-V symbol check #13724

Merged

Add aarch64 qt depends support for cross compiling bitcoin-qt #13696

Merged

ken2812221 changed the title ~~[build] Add risc-v support to gitian~~ [WIP][build] Add risc-v support to gitian Jul 22, 2018

DrahtBot added the Needs rebase label Jul 29, 2018

DrahtBot removed the Needs rebase label Aug 6, 2018

bitcoin deleted a comment from DrahtBot Aug 7, 2018

maflcko added the Needs gitian build label Aug 7, 2018

DrahtBot removed the Needs gitian build label Aug 8, 2018

ken2812221 added 2 commits August 9, 2018 03:34

[depends] Add riscv qt depends support for cross compiling bitcoin-qt

96dda8b

Add risc-v 64-bit to gitian

c4aecd1

bitcoin deleted a comment from DrahtBot Aug 8, 2018

maflcko added the Needs gitian build label Aug 8, 2018

DrahtBot removed the Needs gitian build label Aug 9, 2018

bitcoin deleted a comment from DrahtBot Aug 9, 2018

maflcko added the Needs gitian build label Aug 9, 2018

DrahtBot removed the Needs gitian build label Aug 10, 2018

ken2812221 changed the title ~~[WIP][build] Add risc-v support to gitian~~ [build] Add risc-v support to gitian Aug 16, 2018

maflcko added the Needs gitian build label Aug 16, 2018

laanwj merged commit c4aecd1 into bitcoin:master Aug 16, 2018

ken2812221 deleted the gitian-risc-v branch August 16, 2018 18:36

maflcko removed the Needs gitian build label Aug 17, 2018

bitcoin deleted a comment from DrahtBot Aug 23, 2018

Bushstar mentioned this pull request Sep 4, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#359

Merged

maflcko mentioned this pull request Jan 23, 2021

guix: Build support for macOS #17920

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Conversation

ken2812221 commented Jul 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Jul 17, 2018

Uh oh!

ken2812221 commented Jul 18, 2018

Uh oh!

laanwj commented Jul 19, 2018

Uh oh!

ken2812221 commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Jul 19, 2018

Uh oh!

theuni left a comment

Choose a reason for hiding this comment

Uh oh!

theuni Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

ken2812221 Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

theuni Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

ken2812221 Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

theuni Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

ken2812221 Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

laanwj Jul 19, 2018

Choose a reason for hiding this comment

Uh oh!

ken2812221 Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj commented Jul 20, 2018

Uh oh!

DrahtBot commented Jul 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Aug 8, 2018

Uh oh!

ken2812221 commented Aug 8, 2018

Uh oh!

ken2812221 commented Aug 9, 2018

Uh oh!

laanwj commented Aug 15, 2018

Uh oh!

ken2812221 commented Aug 15, 2018

Uh oh!

laanwj commented Aug 16, 2018

Uh oh!

ken2812221 commented Aug 16, 2018

Uh oh!

laanwj commented Aug 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Aug 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ken2812221 commented Jul 15, 2018 •

edited

Loading

ken2812221 commented Jul 19, 2018 •

edited

Loading

laanwj commented Jul 19, 2018 •

edited

Loading

ken2812221 Jul 19, 2018 •

edited

Loading

DrahtBot commented Jul 22, 2018 •

edited

Loading

laanwj commented Aug 16, 2018 •

edited

Loading