Docs: Control Port not always enabled by default#13681
Docs: Control Port not always enabled by default#13681JBaczuk wants to merge 2 commits intobitcoin:masterfrom
Conversation
|
Please remove the trailing whitespace from the lines you've added. That is what's causing the tests to fail. |
doc/tor.md
Outdated
| configured. For cookie authentication the user running bitcoind must have write access | ||
| to the `CookieAuthFile` specified in Tor configuration. In some cases this is | ||
| configured. It also requires the control socket to be enabled, eg. put `ControlPort 9051` | ||
| in torrc config file. For cookie authentication the user running bitcoind must have write |
doc/tor.md
Outdated
| Connecting to Tor's control socket API requires one of two authentication methods to be | ||
| configured. For cookie authentication the user running bitcoind must have write access | ||
| to the `CookieAuthFile` specified in Tor configuration. In some cases this is | ||
| configured. It also requires the control socket to be enabled, eg. put `ControlPort 9051` |
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| Connecting to Tor's control socket API requires one of two authentication methods to be | ||
| configured. It also requires the control socket to be enabled, e.g. put `ControlPort 9051` | ||
| in `torrc` config file. For cookie authentication the user running bitcoind must have write | ||
| access to the `CookieAuthFile` specified in Tor configuration. In some cases this is |
There was a problem hiding this comment.
This is not your doing, but I think this statement is not correct. It needs read access to the cookie file (to be able to send it for authentication), not write access.
There was a problem hiding this comment.
Seems like the author copied that wording from the tor spec. The user running the tor daemon needs the write access, and the user running bitcoind should only need read.
There was a problem hiding this comment.
ok I've made this change, apologies, I didn't realize this was holding this PR up.
| Needs rebase |
|
Closing this, let me know if you want to pick it up again, but this is taking much too long for a documentation-only change |
|
Apologies, what exactly is holding this up? |
|
@JBaczuk Could you please address the in-line feedback? |
|
@MarcoFalke oh, ok done. |
|
This pull is still closed and it won't let me reopen due to the push. |
|
I didn't know that could happen, what's the proper procedure here? |
|
There hasn't been any substantial discussion, so feel free to open a new pull request in this case. |
|
Ok reopened as #14120 |
fb97437 added note that control port must be enabled and how to do that in torrc config file (Jordan Baczuk) Pull request description: Reopened from #13681 because pushes made it unable to reopen. Tree-SHA512: 34eac14308aef70963b630173cd93916201553d5323ab2de3517d4a78604ae5a7cf8691a314c0af00fe36f0ef19b94a4c371d2e7aa1229d9c603d36c51b115fb
fb97437 added note that control port must be enabled and how to do that in torrc config file (Jordan Baczuk) Pull request description: Reopened from bitcoin#13681 because pushes made it unable to reopen. Tree-SHA512: 34eac14308aef70963b630173cd93916201553d5323ab2de3517d4a78604ae5a7cf8691a314c0af00fe36f0ef19b94a4c371d2e7aa1229d9c603d36c51b115fb
fb97437 added note that control port must be enabled and how to do that in torrc config file (Jordan Baczuk) Pull request description: Reopened from bitcoin#13681 because pushes made it unable to reopen. Tree-SHA512: 34eac14308aef70963b630173cd93916201553d5323ab2de3517d4a78604ae5a7cf8691a314c0af00fe36f0ef19b94a4c371d2e7aa1229d9c603d36c51b115fb
7 participants
added note that for tor to work in automatic mode, the control port must be enabled and also added how to do that by using torrc config file.