lint: Run the CI lint stage on mac by Empact · Pull Request #13728 · bitcoin/bitcoin

Empact · 2018-07-20T22:35:43Z

This helps ensure ongoing compatibility with macOS-distributed version of GNU bash.

Empact · 2018-07-20T22:35:57Z

Inspired by and built on #13720

.travis.yml

practicalswift · 2018-07-21T17:59:54Z

Concept ACK

Nit: macOS ships with GNU bash, albeit an ancient version. Please change "helps ensure ongoing compatibility with BSD bash as well as GNU bash" to something along the lines of "helps ensure ongoing compatibility with the macOS BSD user land and the ancient version of GNU bash shipped with macOS".

sipa · 2018-07-21T21:10:26Z

/usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `<main>': Homebrew must be run under Ruby 2.3! You're running 2.0.0. (RuntimeError)

Empact · 2018-07-22T01:07:36Z

~~wip: I’m rolling back to 10.10~~

DrahtBot · 2018-07-22T13:18:01Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

maflcko · 2018-07-24T12:50:23Z

Might as well do a full depends and bitcoind build when pulling in macos anyway?

scravy

I very much like these changes - love the --exclude change, the -e made me go to the documentation the first time I came across it and I wished it was a more self-explanatory cli switch :-)

.travis.yml

scravy · 2018-08-01T15:41:20Z

ACK d5d76655105d6d338dbc367ae0b54b7433ffeb38

practicalswift · 2018-08-06T15:31:08Z

utACK d5d7665

Closing my PR #13720 in favour of this one.

maflcko · 2018-08-27T11:56:16Z

There are some non-travis related changes here, which should be submitted independently, imo.

I.e. all commits to b24ee76 might go to a separate pull.

Empact · 2018-08-27T17:21:55Z

@MarcoFalke FYI those changes are required to make the lint stage pass when also run on Mac, so I included them to make this PR green. Will extract a second PR for them in case that's helpful.

Sjors · 2019-08-13T16:55:27Z

ACK eefbc9d. Looking forward to seeing more stuff tested on the macOS native build.

fanquake

I feel like I've Concept ACK'd this already, but re-Concept ACK anyways. Left a couple comments inline. It might be handy to base this off #16582, to make it easier to test.

.travis.yml

.travis/lint_04_install.sh

DrahtBot · 2019-09-18T17:20:19Z

Needs rebase

jonasschnelli · 2019-10-09T13:56:21Z

ci/lint/04_install.sh

Probably a good idea to add a travis_retry here as well

style-nit: If you feel like running source ./ci/test/00_setup_env.sh, you can use ${CI_RETRY_EXE} instead, which should also work on non travis hosts (theoretically), obviously not yet in practise.

Added travis_retry and switched -s to --silent for clarity.

@MarcoFalke will plan on a follow-up converting the lint scripts: https://github.com/Empact/bitcoin/tree/travis-retry-lint

Ah, looks like setup_env is already running (because the before_install step is inherited.

https://travis-ci.org/bitcoin/bitcoin/jobs/595662274#L125

ci/lint/04_install.sh

This helps ensure ongoing compatibility with macOS-distributed version of GNU bash.

Declare and assign separately to avoid masking return values. https://github.com/koalaman/shellcheck/wiki/SC2155

Particularly `--with-pcre2` is needed to run `git grep --perl-regexp` in `test/link/check-doc.py`

maflcko · 2019-10-09T18:29:53Z

I am going to merge this under the "experimental umbrella", as it might be needed for #16597

maflcko · 2019-10-09T18:33:27Z

It takes about 10 minutes to boot the macOS on travis. If that is too long, we can revert this.

ACK cd82f75

Show signature and timestamp

Signature:

Timestamp of file with hash 83acb4bc3587c0498eb8a1fc412634b436d9456759eec0634bddf78144e5b4e4 -

fanquake · 2019-10-09T18:34:45Z

It takes about 10 minutes to boot the macOS on travis.

@MarcoFalke Any idea why it takes that long?

maflcko · 2019-10-09T18:36:19Z

@MarcoFalke Any idea why it takes that long?

because travis 🤷

maflcko · 2019-10-10T16:34:40Z

The backlog for macOS can be seen here: https://www.traviscistatus.com/

note to myself: It failed here: https://travis-ci.org/bitcoin/bitcoin/jobs/595893060#L2470

ryanofsky · 2019-10-17T02:50:05Z

I think it's bad that this change seems to now require scripted diffs to run in the macos unix environment. It makes me less inclined to write scripted diffs if I have to somehow get them them to work in macos when I don't use the operating system, and don't have the hardware, and all the unix tools are strange and old.

Also, does this scripted-diff checking script itself not function on macos...?

https://travis-ci.org/bitcoin/bitcoin/jobs/598935472

$ set -o errexit; source ./ci/lint/06_script.sh
sed: 1: "/^-BEGIN VERIFY SCRIPT- ...": unexpected EOF (pending }'s)
Error: missing script for: 3c5edd40ae63daee4de6c58ea4123c66be83119c
Failed
sed: 1: "/^-BEGIN VERIFY SCRIPT- ...": unexpected EOF (pending }'s)
Error: missing script for: 7e271ea765b731c59edbc62790f568af284c7800
Failed

Sjors · 2019-10-17T08:18:25Z

There are some tools / homebrew packages to make macOS scripts behave more like Linux. E.g. https://formulae.brew.sh/formula/gnu-sed

maflcko · 2019-10-17T14:34:29Z

Ok, then lets remove this and macOS users should use the gnu utils that are provided by brew

Empact mentioned this pull request Jul 20, 2018

build: Make lint-locale-dependence.sh work with BSD grep (avoid empty subexpressions) #13720

Closed

Empact changed the title ~~Run the CI lint stage on mac and linux both~~ Scripts and tools: Run the CI lint stage on mac and linux both Jul 20, 2018

fanquake added the Scripts and tools label Jul 21, 2018

fanquake reviewed Jul 21, 2018

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

Empact force-pushed the bsd-bash-compatibility branch from 052ed45 to 1598438 Compare July 21, 2018 17:04

Empact force-pushed the bsd-bash-compatibility branch 2 times, most recently from 7436739 to 3a9c712 Compare July 21, 2018 19:35

Empact force-pushed the bsd-bash-compatibility branch from 3a9c712 to 18591b2 Compare July 21, 2018 21:54

Empact force-pushed the bsd-bash-compatibility branch from 18591b2 to f94eafa Compare July 24, 2018 01:28

Empact force-pushed the bsd-bash-compatibility branch 2 times, most recently from 3c87951 to 3d8c654 Compare July 28, 2018 18:19

Empact mentioned this pull request Jul 31, 2018

travis: WIP - build and run tests on os: osx #13816

Closed

scravy suggested changes Aug 1, 2018

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

Empact force-pushed the bsd-bash-compatibility branch from 3d8c654 to d5d7665 Compare August 1, 2018 15:20

scravy approved these changes Aug 2, 2018

View reviewed changes

DrahtBot mentioned this pull request Aug 3, 2018

travis: move script sections to files in .travis/ subject to shellcheck #13863

Merged

DrahtBot mentioned this pull request Aug 14, 2018

~~Correctly~~ terminate HTTP server #13501

Closed

DrahtBot added the Needs rebase label Aug 27, 2018

Empact force-pushed the bsd-bash-compatibility branch from d5d7665 to daef159 Compare August 27, 2018 17:21

DrahtBot removed the Needs rebase label Aug 27, 2018

Empact changed the title ~~WIP: Scripts and tools: Run the CI lint stage on mac~~ lint: Run the CI lint stage on mac Jun 11, 2019

Empact force-pushed the bsd-bash-compatibility branch 3 times, most recently from 66cb5ef to 59b11e6 Compare June 17, 2019 15:15

Empact force-pushed the bsd-bash-compatibility branch from 59b11e6 to a6ed86d Compare June 22, 2019 05:52

DrahtBot added the Needs rebase label Jul 8, 2019

Empact force-pushed the bsd-bash-compatibility branch from a6ed86d to eefbc9d Compare July 8, 2019 22:27

DrahtBot removed the Needs rebase label Jul 9, 2019

Sjors mentioned this pull request Aug 13, 2019

Travis: run full test suite on native macOS #16597

Merged

fanquake reviewed Aug 14, 2019

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

.travis/lint_04_install.sh Show resolved Hide resolved

DrahtBot added the Needs rebase label Aug 15, 2019

Empact force-pushed the bsd-bash-compatibility branch from eefbc9d to 200f029 Compare September 7, 2019 18:19

DrahtBot removed the Needs rebase label Sep 7, 2019

jonasschnelli reviewed Oct 9, 2019

View reviewed changes

maflcko reviewed Oct 9, 2019

View reviewed changes

ci/lint/04_install.sh Outdated Show resolved Hide resolved

Empact added 3 commits October 9, 2019 15:49

lint: Run the linters against Mac OS on Travis

615ff4e

This helps ensure ongoing compatibility with macOS-distributed version of GNU bash.

lint: Fix shellcheck SC2155

eafa747

Declare and assign separately to avoid masking return values. https://github.com/koalaman/shellcheck/wiki/SC2155

lint: Install grep and git via brew on mac for --perl-regexp

cd82f75

Particularly `--with-pcre2` is needed to run `git grep --perl-regexp` in `test/link/check-doc.py`

maflcko mentioned this pull request Oct 17, 2019

ci: Cleanup macOS runs #17176

Merged

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

Conversation

Empact commented Jul 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Empact commented Jul 20, 2018

Uh oh!

Uh oh!

practicalswift commented Jul 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sipa commented Jul 21, 2018

Uh oh!

Empact commented Jul 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Jul 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

maflcko commented Jul 24, 2018

Uh oh!

scravy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scravy commented Aug 1, 2018

Uh oh!

practicalswift commented Aug 6, 2018

Uh oh!

maflcko commented Aug 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Empact commented Aug 27, 2018

Uh oh!

Sjors commented Aug 13, 2019

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DrahtBot commented Sep 18, 2019

Uh oh!

jonasschnelli Oct 9, 2019

Choose a reason for hiding this comment

Uh oh!

maflcko Oct 9, 2019

Choose a reason for hiding this comment

Uh oh!

Empact Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko Oct 9, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maflcko commented Oct 9, 2019

Uh oh!

maflcko commented Oct 9, 2019

Uh oh!

fanquake commented Oct 9, 2019

Uh oh!

maflcko commented Oct 9, 2019

Uh oh!

maflcko commented Oct 10, 2019

Uh oh!

ryanofsky commented Oct 17, 2019

Uh oh!

Sjors commented Oct 17, 2019

Uh oh!

maflcko commented Oct 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Empact commented Jul 20, 2018 •

edited

Loading

practicalswift commented Jul 21, 2018 •

edited

Loading

Empact commented Jul 22, 2018 •

edited

Loading

DrahtBot commented Jul 22, 2018 •

edited

Loading

maflcko commented Aug 27, 2018 •

edited

Loading

Empact Oct 9, 2019 •

edited

Loading

maflcko commented Oct 17, 2019 •

edited

Loading