scripted-diff: Remove trailing whitespaces#13753
Conversation
|
Ironically rejected by a linter :-) Concept ACK: means I can turn "remove trailing whitespace" on again in my editor, without it changing stuff all over the file. |
promag
force-pushed
the
remove-trailing-whitespaces
branch
from
b32fa1a to
b3ce595
Compare
Right, or skip hunks. Or this #13248 (comment). |
|
ACK b3ce5956291cd25ddb654e1dfb543658f87cdeb1, any difference between |
promag
force-pushed
the
remove-trailing-whitespaces
branch
from
b3ce595 to
2ffcfc6
Compare
|
@MarcoFalke in order to use |
|
Note that the flag for gnu sed is |
promag
force-pushed
the
remove-trailing-whitespaces
branch
from
2ffcfc6 to
93538be
Compare
|
You'd have to remove the trailing |
-BEGIN VERIFY SCRIPT- sed --in-place'' --regexp-extended 's/[[:space:]]+$//g' $(git grep -I --files-with-matches --extended-regexp '[[:space:]]+$' -- src test ':!*.svg' ':!src/crypto/sha256_sse4*' ':!src/leveldb' ':!src/qt/locale' ':!src/secp256k1' ':!src/univalue') -END VERIFY SCRIPT-
promag
force-pushed
the
remove-trailing-whitespaces
branch
from
93538be to
12dd101
Compare
|
@MarcoFalke done |
|
utACK 12dd101 |
|
utACK 12dd101 |
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
12dd101 scripted-diff: Remove trailing whitespaces (João Barbosa) Pull request description: The script test/lint/lint-whitespace.sh should prevent new cases. This happens in some pulls where the code editor and the author 'git add's them, so this would fix it all. Tree-SHA512: bcdd3472fcd01a2754e52212c7db1de2fdc422728b06785481954a27162fb72001cb73708329cc56e95bcc5e45c1348ebc4eacc2ccfa6aa12413c7ec450b6a33
|
So glad this is done. Thanks @promag! |
-BEGIN VERIFY SCRIPT- sed --in-place'' --regexp-extended 's/[[:space:]]+$//g' $(git grep -I --files-with-matches --extended-regexp '[[:space:]]+$' -- src test ':!*.svg' ':!src/crypto/sha256_sse4*' ':!src/leveldb' ':!src/qt/locale' ':!src/secp256k1' ':!src/univalue') -END VERIFY SCRIPT- Signed-off-by: pasta <[email protected]>
7 participants
The script test/lint/lint-whitespace.sh should prevent new cases.
This happens in some pulls where the code editor and the author 'git add's them, so this would fix it all.