Closed
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 30, 2018
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
from
ee20997 to
fa7a9de
Compare
This was referenced Jul 30, 2018
promag
reviewed
Jul 31, 2018
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Last commit is overwhelming. Could prefix with wip: until dependencies are merged?
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
9 times, most recently
from
d2dff9d to
fe0fe6f
Compare
This was referenced Aug 8, 2018
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
2 times, most recently
from
d5d9d6e to
e4ccef5
Compare
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
4 times, most recently
from
48cdddc to
930e231
Compare
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
from
8a288dc to
6a7feb6
Compare
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
from
6a7feb6 to
33a025b
Compare
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
from
33a025b to
566cc51
Compare
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
6 times, most recently
from
713311f to
70cbf1e
Compare
added 4 commits
July 13, 2019 10:23
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
from
70cbf1e to
9aa48e1
Compare
maflcko
force-pushed
the
Mf1807-txpoolStacked
branch
from
9aa48e1 to
421de16
Compare
5tefan
added a commit
to 5tefan/dash
that referenced
this pull request
Aug 10, 2021
…tor impl details faa1a74 tx pool: Use class methods to hide raw map iterator impl details (MarcoFalke) Pull request description: ATMP et al would often use map iterator implementation details such as `end()` or `find()`, which is acceptable in current code. However, this not only makes it impossible to turn the maps into private members in the future but also makes it harder to replace the maps with different data structures. This is required for and split off of bitcoin#13804 Tree-SHA512: 4f9017fd1d98d9df49d25bba92655a4a97755eea161fd1cbb565ceb81bbc2b4924129d214f8a29563a77e3d8eef85a67c81245ecdc9a9e5292d419922a93cb88
5tefan
added a commit
to 5tefan/dash
that referenced
this pull request
Aug 12, 2021
…tor impl details faa1a74 tx pool: Use class methods to hide raw map iterator impl details (MarcoFalke) Pull request description: ATMP et al would often use map iterator implementation details such as `end()` or `find()`, which is acceptable in current code. However, this not only makes it impossible to turn the maps into private members in the future but also makes it harder to replace the maps with different data structures. This is required for and split off of bitcoin#13804 Tree-SHA512: 4f9017fd1d98d9df49d25bba92655a4a97755eea161fd1cbb565ceb81bbc2b4924129d214f8a29563a77e3d8eef85a67c81245ecdc9a9e5292d419922a93cb88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a layer around an immutable tx pool. The layer can be seen as a temporary throw-away shell that provides the same interface as
CTxMemPool. Its primary purpose right now is to be passed into ATMP while testing acceptance of several (potentially depending) transaction and then to be discarded.One use case could be to determine if smart contracts that are set up with multiple txs would be accepted by current consensus and policy rules.
In the future it could be extended to support recursive wrapping of layers or a way to commit changes that happened in the layer to the underlying pool or layer. Furthermore, it could be extended to be revivable after changes to the underlying layer happened. (As opposed to be single-use)