contrib: Remove debian and rpm subfolder#13809
Conversation
maflcko
force-pushed
the
Mf1808-debianContrib
branch
from
fadc03f to
faa3656
Compare
maflcko
changed the title
maflcko
force-pushed
the
Mf1808-debianContrib
branch
from
faa3656 to
fa0e1e2
Compare
|
utACK fa0e1e2 1654 lines (re)moved – very nice! |
|
utACK fa0e1e2 Small diff for debian dir, but nothing significant. |
|
Thanks for picking this up, utACK fa0e1e2 Edit: huh that was strange, looked like github lost my comment at first |
|
utACK fa0e1e2 Only nit could be to drop: from contrib/debian/copyright, as Edit: @MarcoFalke What do you mean by:
If we are copying the files from /packaging/ back in here pre-release then the above nit is redundant. |
|
Currently people tend to be pretty good about updating contrib/debian/copyright when things change, which is super nice cause I won't ever keep track of it. It may make sense to move it from contrib/debian/copyright to contrib/copyright or something like that. |
|
It is still in the debian format, so I think it makes sense to keep in the debian folder. (Also I don't feel like updating all the internal and external links to the file) |
|
If anyone feels strongly about that, it should be done in a separate commit to not invalidate the previous review. |
fa0e1e2 contrib: Remove debian and rpm subfolders (MarcoFalke) Pull request description: The folders are now located here: * https://github.com/bitcoin-core/packaging/tree/master/debian * https://github.com/bitcoin-core/packaging/tree/master/rpm Note that I kept the copyright file, so that it can be updated for our purposes in the commit that adds new files. Tree-SHA512: 4c919e8e04cdcc56f2c4c16e83c68d5ec74b7e4438ca54222a37f85cf604b77880393d1a0004f16f270ab04ee00b2060129c5c2e0b34815679940f1c3b5754f3
fa0e1e2 contrib: Remove debian and rpm subfolders (MarcoFalke) Pull request description: The folders are now located here: * https://github.com/bitcoin-core/packaging/tree/master/debian * https://github.com/bitcoin-core/packaging/tree/master/rpm Note that I kept the copyright file, so that it can be updated for our purposes in the commit that adds new files. Tree-SHA512: 4c919e8e04cdcc56f2c4c16e83c68d5ec74b7e4438ca54222a37f85cf604b77880393d1a0004f16f270ab04ee00b2060129c5c2e0b34815679940f1c3b5754f3
6 participants
The folders are now located here:
Note that I kept the copyright file, so that it can be updated for our purposes in the commit that adds new files.