gui: don't disable the sync overlay when wallet is disabled#13848
gui: don't disable the sync overlay when wallet is disabled#13848fanquake wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
I don't think this message makes much sense when the wallet is disabled? It talks about a wallet and spending coins. |
| No more conflicts as of last run. |
|
Concept ACK, though indeed removing the wallet specific warning makes sense. |
|
FYI in #11826 there is discussion about changing the overlay and I was planning to work on that after 0.17 branch. |
|
I think the modal overlay with the sync-info should show but the warning part (icon / text) should only be visible when a wallet is loaded. |
| Needs rebase |
|
Seems like it would be better to just add the missing data to the main Information tab. |
In principle that's per-wallet and supposed to have wallet information, not node/global information. |
|
@promag I'm closing and labelling up for grabs. Feel free to work on this. |
|
Removing up for grabs, as this has been picked up in #15084. |
…bled b3b6b6f gui: don't disable the sync overlay when wallet is disabled (Ben Carman) Pull request description: Continuation of #13848. When running with `-disablewallet` the sync modal is now available by clicking on the progress bar or `syncing` icon. [Current Image of what the window looks like](https://imgur.com/6LsoT2l) Fixes #13828. ACKs for top commit: jonasschnelli: Tested ACK b3b6b6f Tree-SHA512: 325bc22a0b692bfb8fcc9d84e02dfc506146028b97b3609e23c2c45288c79b8aead1ad2e9b8d692f5f6771b4d2aee63fbe71bfaeaf17d260865da32ab3631e07
…is disabled b3b6b6f gui: don't disable the sync overlay when wallet is disabled (Ben Carman) Pull request description: Continuation of bitcoin#13848. When running with `-disablewallet` the sync modal is now available by clicking on the progress bar or `syncing` icon. [Current Image of what the window looks like](https://imgur.com/6LsoT2l) Fixes bitcoin#13828. ACKs for top commit: jonasschnelli: Tested ACK b3b6b6f Tree-SHA512: 325bc22a0b692bfb8fcc9d84e02dfc506146028b97b3609e23c2c45288c79b8aead1ad2e9b8d692f5f6771b4d2aee63fbe71bfaeaf17d260865da32ab3631e07
7 participants
When running with
-disablewalletthe sync modal is now available by clicking on the progress bar orsyncingicon.Fixes #13828.