lint: Make format string linter understand basic template parameter syntax#13939
Merged
maflcko merged 1 commit intobitcoin:masterfrom Aug 13, 2018
Merged
Conversation
Member
|
utACK 4441ad6 |
Contributor
Author
|
The first |
Contributor
|
Tested ACK 4441ad6. But |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 29, 2021
… template parameter syntax 4441ad6 Make format string linter understand basic template parameter syntax (practicalswift) Pull request description: Make format string linter understand basic template parameter syntax. Fixes issue described in bitcoin#13705 (comment). Thanks to @ken2812221 for reporting! Tree-SHA512: 8fb995bc6b29d8b9926ef5969e02cf71c494e829434fcdeb4ed5fabad5ab96e86e5b8eea705e8a416927757b4fa4e58abc0fd4f483daa58c94e2c6fdcb8ee822
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 11, 2022
Summary: While working on D10815, I got a false positive error from `arc lint` ``` Lint: String formatting function arguments mismatch strprintf( "%s (%d)", std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>, wchar_t>() .to_bytes(buf), err) Expected 2 argument(s) after format string but found 3 argument(s) ``` This is a backport of [[bitcoin/bitcoin#13939 | core#13939]] Test Plan: run `arc lint` on D10815 and make sure it does not produce a false positive error Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make format string linter understand basic template parameter syntax.
Fixes issue described in #13705 (comment).
Thanks to @ken2812221 for reporting!