lint: Make all linters work under the default macOS dev environment (build-osx.md) by practicalswift · Pull Request #14115 · bitcoin/bitcoin

practicalswift · 2018-08-30T23:04:31Z

The linters are thoroughly tested under Ubuntu which is what we use in Travis. When reading #14041 I understood that some developers were experiencing problems when running the linters on their local machines.

Assuming these local machines were running macOS I installed a fresh macOS VM, followed the instructions in build-osx.md and ran the linters.

This PR contains the changes needed to make lint-all.sh run as expected.

Ideally the linters would continuously run also under a Travis macOS environment to make sure we catch these kind of issues before merge.

…macOS

…ion installed by brew

…ings. The brew installed flake8 version is Python 2 based and does not work.

DrahtBot · 2018-08-31T02:21:40Z

Note to reviewers: This pull request conflicts with the following ones:

lint: Run the CI lint stage on mac #13728 (Scripts and tools: Run the CI lint stage on mac and linux both by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj · 2018-08-31T11:28:30Z

Concept ACK

maflcko · 2018-08-31T11:49:35Z

utACK 341f7c7

Empact · 2018-09-01T20:12:42Z

See also: #13728 which is similar but fixes the linter errors rather than disabling them, and runs the linters on macos via CI.

fanquake · 2018-09-02T05:38:23Z

Tested on macOS 10.13.6, master 2070a54 has a bunch of warnings/failures:

./test/lint/lint-all.sh
test/lint/lint-format-strings.sh: line 36: mapfile: command not found
grep: empty (sub)expression
/usr/local/lib/python3.7/site-packages/pycodestyle.py:113: FutureWarning: Possible nested set at position 1
  EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')
grep: empty (sub)expression
Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in .travis/lint_04_install.sh
grep: empty (sub)expression
^---- failure generated from test/lint/lint-shell-locale.sh

Using 341f7c7 and after brew install spellcheck and pip3 install flake8, all linters seem to run, with no warnings.

Did not check if this breaks anything on a different OS etc.
tACK 341f7c7

practicalswift · 2018-09-05T07:44:43Z

Please review :-)

… environment (build-osx.md) 341f7c7 macOS fix: Check for correct version of flake8 to avoid spurious warnings. The brew installed flake8 version is Python 2 based and does not work. (practicalswift) 908a559 macOS fix: Add excludes for checks added in the newer shellcheck version installed by brew (practicalswift) ec4d57b macOS fix: Work around empty (sub)expression error when using BSD grep (practicalswift) b57d7d9 macOS fix: Avoid mapfile due to ancient version of bash shipped with macOS (practicalswift) Pull request description: The linters are thoroughly tested under Ubuntu which is what we use in Travis. When reading #14041 I understood that some developers were experiencing problems when running the linters on their local machines. Assuming these local machines were running macOS I installed a fresh macOS VM, followed the instructions in `build-osx.md` and ran the linters. This PR contains the changes needed to make `lint-all.sh` run as expected. Ideally the linters would continuously run also under a Travis macOS environment to make sure we catch these kind of issues before merge. Tree-SHA512: b39c9a970d14d27db1fb592539923c0bc676b5217f415d02fda3f17bf54d46faa172376e8a3ecab07ca68a3acba9aebe00b2b1b2161b2a36b85fbb672e7efb5c

…cOS dev environment (build-osx.md) 341f7c7 macOS fix: Check for correct version of flake8 to avoid spurious warnings. The brew installed flake8 version is Python 2 based and does not work. (practicalswift) 908a559 macOS fix: Add excludes for checks added in the newer shellcheck version installed by brew (practicalswift) ec4d57b macOS fix: Work around empty (sub)expression error when using BSD grep (practicalswift) b57d7d9 macOS fix: Avoid mapfile due to ancient version of bash shipped with macOS (practicalswift) Pull request description: The linters are thoroughly tested under Ubuntu which is what we use in Travis. When reading bitcoin#14041 I understood that some developers were experiencing problems when running the linters on their local machines. Assuming these local machines were running macOS I installed a fresh macOS VM, followed the instructions in `build-osx.md` and ran the linters. This PR contains the changes needed to make `lint-all.sh` run as expected. Ideally the linters would continuously run also under a Travis macOS environment to make sure we catch these kind of issues before merge. Tree-SHA512: b39c9a970d14d27db1fb592539923c0bc676b5217f415d02fda3f17bf54d46faa172376e8a3ecab07ca68a3acba9aebe00b2b1b2161b2a36b85fbb672e7efb5c

…cOS dev environment (build-osx.md) 341f7c7 macOS fix: Check for correct version of flake8 to avoid spurious warnings. The brew installed flake8 version is Python 2 based and does not work. (practicalswift) 908a559 macOS fix: Add excludes for checks added in the newer shellcheck version installed by brew (practicalswift) ec4d57b macOS fix: Work around empty (sub)expression error when using BSD grep (practicalswift) b57d7d9 macOS fix: Avoid mapfile due to ancient version of bash shipped with macOS (practicalswift) Pull request description: The linters are thoroughly tested under Ubuntu which is what we use in Travis. When reading bitcoin#14041 I understood that some developers were experiencing problems when running the linters on their local machines. Assuming these local machines were running macOS I installed a fresh macOS VM, followed the instructions in `build-osx.md` and ran the linters. This PR contains the changes needed to make `lint-all.sh` run as expected. Ideally the linters would continuously run also under a Travis macOS environment to make sure we catch these kind of issues before merge. Tree-SHA512: b39c9a970d14d27db1fb592539923c0bc676b5217f415d02fda3f17bf54d46faa172376e8a3ecab07ca68a3acba9aebe00b2b1b2161b2a36b85fbb672e7efb5c

practicalswift added 4 commits August 31, 2018 00:51

macOS fix: Avoid mapfile due to ancient version of bash shipped with …

b57d7d9

…macOS

macOS fix: Work around empty (sub)expression error when using BSD grep

ec4d57b

macOS fix: Add excludes for checks added in the newer shellcheck vers…

908a559

…ion installed by brew

macOS fix: Check for correct version of flake8 to avoid spurious warn…

341f7c7

…ings. The brew installed flake8 version is Python 2 based and does not work.

fanquake added the Scripts and tools label Aug 30, 2018

practicalswift mentioned this pull request Aug 30, 2018

Linter fixes #14041

Closed

DrahtBot mentioned this pull request Aug 31, 2018

lint: Run the CI lint stage on mac #13728

Merged

practicalswift mentioned this pull request Aug 31, 2018

wallet: Remove unused local variable old_label #14117

Closed

maflcko merged commit 341f7c7 into bitcoin:master Sep 5, 2018

Bushstar mentioned this pull request Oct 11, 2018

Updates from bitcoin/master FeatherCoin/Feathercoin#366

Merged

hebasto mentioned this pull request Jul 2, 2019

scripts and tools: Update ShellCheck linter #16327

Merged

str4d mentioned this pull request Oct 27, 2020

Backport useful lints from upstream zcash/zcash#4829

Merged

practicalswift deleted the linter-macos branch April 10, 2021 19:35

bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lint: Make all linters work under the default macOS dev environment (build-osx.md)#14115

lint: Make all linters work under the default macOS dev environment (build-osx.md)#14115
maflcko merged 4 commits intobitcoin:masterfrom
practicalswift:linter-macos

practicalswift commented Aug 30, 2018 •

edited

Loading

Uh oh!

DrahtBot commented Aug 31, 2018

Uh oh!

laanwj commented Aug 31, 2018

Uh oh!

maflcko commented Aug 31, 2018

Uh oh!

Empact commented Sep 1, 2018

Uh oh!

fanquake commented Sep 2, 2018

Uh oh!

practicalswift commented Sep 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

practicalswift commented Aug 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Aug 31, 2018

Uh oh!

laanwj commented Aug 31, 2018

Uh oh!

maflcko commented Aug 31, 2018

Uh oh!

Empact commented Sep 1, 2018

Uh oh!

fanquake commented Sep 2, 2018

Uh oh!

practicalswift commented Sep 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

practicalswift commented Aug 30, 2018 •

edited

Loading