gui: Add Windows taskbar progress by ken2812221 · Pull Request #14137 · bitcoin/bitcoin

ken2812221 · 2018-09-03T05:21:53Z

This PR adds an progress bar at taskbar on Windows. This progress bar will hide when full synced.

luke-jr

Should this also show splashscreen progress?

luke-jr · 2018-09-03T06:07:19Z

src/qt/bitcoingui.cpp

Why + 0.5? (add a comment)

This is as same as here , I guess this is to round the value

bitcoin/src/qt/bitcoingui.cpp

Line 856 in 68f3c7e

progressBar->setValue(nVerificationProgress * 1000000000.0 + 0.5);

Use qRound?

Ok, I'll use qRound after gitian build done.

fanquake · 2018-09-03T07:52:47Z

Concept ACK. Thanks for following up on this so quickly, and using QWinTaskbarProgress .

Given that this is an entirely new implementation, and includes the build system changes, I don't think you need to cherry-pick/include the other committer.

I'll test on a Windows VM shortly.

jonasschnelli · 2018-09-03T11:10:04Z

Concept ACK (haven't looked at the code though)

promag

Much better, thanks!

promag · 2018-09-03T12:44:38Z

src/qt/bitcoingui.h

Use follow declaration instead?

What do you mean "follow declaration"?

Ops, forward declaration.

Because you don't need to pull in the entire header file (+ what ever it includes) when using just a pointer. It's preferred in case like this to reduce compile times etc. Include it in CPP instead.

☝️also, look in other headers, it's already a recurring practice.

Oh, I saw that QT_NAMESPACE. I'll do that after gitian build finished too.

promag · 2018-09-03T12:45:37Z

src/qt/bitcoingui.cpp

Use qRound?

ken2812221 · 2018-09-04T01:00:48Z

I have no idea what's going on in gitian build. I am able to build this locally. Why does qtwinextras not exist?

sha256sum: /home/ubuntu/cache/common/qtwinextras-opensource-src-5.9.6.tar.xz: No such file or directory
/home/ubuntu/cache/common/qtwinextras-opensource-src-5.9.6.tar.xz: FAILED open or read
sha256sum: WARNING: 1 listed file could not be read

ken2812221 · 2018-09-04T14:17:13Z

a99f9caf92346d9c0bf823b2e3c2bcc44f7d9c6a6205050b985e63f5e3ed0ee1 bitcoin-0.17.99-win32-debug.zip
044347527dd20eb4081cdbc9acd8adc05a97925854169affcf191b915abeef8d bitcoin-0.17.99-win32-setup-unsigned.exe
61b745860cd74c0fb93c8cc1fbfae897589b88084f3d298688ff4ec16e4782f1 bitcoin-0.17.99-win32.zip
fbbc87b50c16cd027aeb9a1ccb5a16320c414f92252c4312b605223cb4673e7a bitcoin-0.17.99-win64-debug.zip
9b2b7536863379e4977d8dcf80486ee2343e60a7fda5a20c39aaff03ba66b5c2 bitcoin-0.17.99-win64-setup-unsigned.exe
50ab47bbb18eae55fc994b3d5b274208cbeae4e379b75092e34501b4aa35d485 bitcoin-0.17.99-win64.zip
92eaedf473b4bc36dc3524d57d2ea5cee1afa12999458b0ce352e422dbe26f61 bitcoin-win-0.18-build.assert

This is my gitian build result for 954d19aff18dc128e3208275b65facd7b55cd852 using ./gitian-build.py -bnDpj4 -m6000 -ow 0 14137

maflcko · 2018-09-04T16:44:07Z

I may have to purge the cache? Did a rm -r gitian-builder/cache/

maflcko · 2018-09-05T13:34:36Z

@jonasschnelli Could you try to see if your gitian build script also fails here?

ken2812221 · 2018-09-06T09:47:50Z

I may know what's going on. makefile would check only the source file listed in .stamp file

bitcoin/depends/Makefile

Lines 153 to 158 in adf27b5

    
           define check_or_remove_sources 
        
             mkdir -p $($(package)_source_dir); cd $($(package)_source_dir); \ 
        
             test -f $($(package)_fetched) && ( $(build_SHA256SUM) -c $($(package)_fetched) >/dev/null 2>/dev/null || \ 
        
               ( echo "Checksum missing or mismatched for $(package) source. Forcing re-download."; \ 
        
                 rm -f $($(package)_all_sources) $($(1)_fetched))) || true 
        
           endef

ken2812221 · 2018-09-06T11:50:08Z

@MarcoFalke This should work now.

donaloconnor · 2018-09-08T21:58:33Z

tACK c3c0022 on Win10

jonasschnelli · 2018-09-25T18:43:11Z

Tested on Win10 via gitian build https://bitcoin.jonasschnelli.ch/build/797 but can't see the status bar:

ken2812221 · 2018-09-25T18:47:48Z

The status bar would hide on 100%. Should I make it always be visible?

jonasschnelli · 2018-09-25T19:05:45Z

@ken2812221: Okay. I see. Any good test plan how to test this on regtest?

ken2812221 · 2018-09-25T19:12:15Z

Okay. I see. Any good test plan how to test this on regtest?

Hmm. I don't think there is a good way to make it not to be 100% on regtest. I would have to use testnet and -reindex to test it.

maflcko · 2018-09-25T19:13:59Z

I guess you'd have to set nTime of the blocks to last year or so?

ken2812221 · 2018-10-06T15:37:10Z

Update: Now the taskbar progress show/hide along with the modaloverlay. It can be easily tested on regtest.

DrahtBot · 2018-10-20T10:30:14Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#15581 (depends: Make less assumptions about build env by dongcarl)
#15277 ([Help Wanted] contrib: Enable building in Guix containers by dongcarl)
#15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
#14920 (Build: enable -Wdocumentation via isystem by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2018-10-20T10:44:16Z

depends/Makefile

Why is this change required?

See above. The current build system only detect the first file is changed or not, so winextra would not be downloaded in you have the source file cache, but it would be re-built(which cause an error). This make the Makefile detect the file amount to be exactly match.

DrahtBot · 2019-03-18T16:00:00Z

Needs rebase

maflcko · 2019-03-18T16:46:19Z

depends/packages/qt.mk

-  tar --strip-components=1 -xf $($(package)_source_dir)/$($(package)_qttools_file_name) -C qttools
+  tar --strip-components=1 -xf $($(package)_source_dir)/$($(package)_qttools_file_name) -C qttools && \
+  mkdir qtwinextras && \
+  tar --strip-components=1 -xf $($(package)_source_dir)/$($(package)_qtwinextras_file_name) -C qtwinextras


Needs rebase to add the --no-same-owner

luke-jr · 2019-04-22T19:13:58Z

depends/packages/qt.mk

 $(package)_qttools_sha256_hash=50e75417ec0c74bb8b1989d1d8e981ee83690dce7dfc0c2169f7c00f397e5117

+$(package)_qtwinextras_file_name=qtwinextras-$($(package)_suffix)
+$(package)_qtwinextras_sha256_hash=794090446d33eecf9eb3f3a4f6f13b3e7ab5307936f8d21e4a76e7b6ba79125d


This hash needs to be updated for the current version.

fanquake · 2019-07-03T06:14:01Z

Closing as up for grabs. @sipsorcery, @NicolasDorier either of you might be interested in picking this up if you think it will be an improvement to Qt on Windows.

NicolasDorier · 2019-07-03T12:14:03Z

I will probably pick it up once we get #15529

fanquake added GUI Windows labels Sep 3, 2018

luke-jr reviewed Sep 3, 2018

View reviewed changes

fanquake added the Needs gitian build label Sep 3, 2018

promag reviewed Sep 3, 2018

View reviewed changes

DrahtBot removed the Needs gitian build label Sep 3, 2018

maflcko added the Needs gitian build label Sep 4, 2018

DrahtBot removed the Needs gitian build label Sep 5, 2018

bitcoin deleted a comment from DrahtBot Sep 5, 2018

bitcoin deleted a comment from DrahtBot Sep 6, 2018

maflcko added the Needs gitian build label Sep 6, 2018

DrahtBot removed the Needs gitian build label Sep 7, 2018

bitcoin deleted a comment from DrahtBot Sep 25, 2018

ken2812221 changed the title ~~gui: Add Windows taskbar progress~~ [WIP] gui: Add Windows taskbar progress Oct 6, 2018

ken2812221 changed the title ~~[WIP] gui: Add Windows taskbar progress~~ gui: Add Windows taskbar progress Oct 7, 2018

fanquake reviewed Oct 20, 2018

View reviewed changes

DrahtBot mentioned this pull request Oct 20, 2018

macOS: disable AppNap during sync #12783

Merged

This was referenced Oct 28, 2018

qt: Cleanup MacDockIconHandler class #14597

Merged

gui: Add GUIUtil::bringToFront #14123

Merged

DrahtBot added the Needs rebase label Nov 10, 2018

gui: Add Windows taskbar progress

18eb4db

DrahtBot removed the Needs rebase label Nov 10, 2018

DrahtBot added the Needs rebase label Mar 18, 2019

maflcko reviewed Mar 18, 2019

View reviewed changes

luke-jr reviewed Apr 22, 2019

View reviewed changes

fanquake added the Up for grabs label Jul 3, 2019

fanquake closed this Jul 3, 2019

luke-jr mentioned this pull request Oct 21, 2019

gui: Add Windows taskbar progress #17213

Closed

fanquake removed the Up for grabs label Oct 21, 2019

laanwj removed the Needs rebase label Oct 24, 2019

luke-jr mentioned this pull request Apr 1, 2020

Bugfix: devtools/symbol-check: Check PE libraries case-insensitively #18490

Closed

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Conversation

ken2812221 commented Sep 3, 2018

Uh oh!

luke-jr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fanquake commented Sep 3, 2018

Uh oh!

jonasschnelli commented Sep 3, 2018

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ken2812221 commented Sep 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ken2812221 commented Sep 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Sep 4, 2018

Uh oh!

maflcko commented Sep 5, 2018

Uh oh!

ken2812221 commented Sep 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ken2812221 commented Sep 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donaloconnor commented Sep 8, 2018

Uh oh!

jonasschnelli commented Sep 25, 2018

Uh oh!

ken2812221 commented Sep 25, 2018

Uh oh!

jonasschnelli commented Sep 25, 2018

Uh oh!

ken2812221 commented Sep 25, 2018

Uh oh!

maflcko commented Sep 25, 2018

Uh oh!

ken2812221 commented Oct 6, 2018

Uh oh!

DrahtBot commented Oct 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DrahtBot commented Mar 18, 2019

Uh oh!

Choose a reason for hiding this comment

ken2812221 commented Sep 4, 2018 •

edited

Loading

ken2812221 commented Sep 4, 2018 •

edited

Loading

ken2812221 commented Sep 6, 2018 •

edited

Loading

ken2812221 commented Sep 6, 2018 •

edited

Loading

DrahtBot commented Oct 20, 2018 •

edited

Loading