Refactor SelectCoinsMinConf() and add unit tests#1416
Merged
gavinandresen merged 5 commits intobitcoin:masterfrom Jun 14, 2012
Merged
Refactor SelectCoinsMinConf() and add unit tests#1416gavinandresen merged 5 commits intobitcoin:masterfrom
gavinandresen merged 5 commits intobitcoin:masterfrom
Conversation
AvailableCoins() makes a vector of available outputs which is then passed to SelectCoinsMinConf(). This allows unit tests to test the coin selection algorithm without having the whole blockchain available.
…e. sub-cent change.
…ndomized coin selection.
Closed
Contributor
|
ACK. It makes ./test_bitcoin spew tons of "best subset" messages, but that's not your fault. |
This was referenced Jun 12, 2012
Member
|
ACK |
1 similar comment
Contributor
|
ACK |
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
452a461 [GUI] Add more room to contacts dropdown (random-zebra) Pull request description: Make contacts dropdown a little bit higher, so at least 4 addresses fit  ---  --- Closes bitcoin#1416 ACKs for top commit: Fuzzbawls: ACK 452a461 furszy: utACK 452a461 . Tree-SHA512: 5dd14f27057667d8e8e593f4a1a4dd01cac6c6ed4f2f45d3f52211823630e8c72ca6efdb193dd7230f013b00775e66d2e43ed47d692173ec6f205b1c46242ac3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AvailableCoins() makes a vector of available outputs which is then passed to SelectCoinsMinConf(). This allows unit tests to test the coin selection algorithm without having the whole blockchain available.
This is an updated (with changes made in #1017, but not Coin Control itself) and rebased form of #905.