travis: Save cache even when build or test fail#14231
Merged
maflcko merged 1 commit intobitcoin:masterfrom Dec 3, 2018
ken2812221:travis-save-cache-on-error
Merged
travis: Save cache even when build or test fail#14231maflcko merged 1 commit intobitcoin:masterfrom ken2812221:travis-save-cache-on-error
maflcko merged 1 commit intobitcoin:masterfrom
ken2812221:travis-save-cache-on-error
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced Sep 16, 2018
Contributor
|
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 3, 2018
d3ecc3d travis: Save cache on build error (Chun Kuan Lee) Pull request description: In current travis setup, the job will terminate immediately if an error occur. There is no chance to save the cache. This was accidentally introduced by bitcoin#13863. This PR is to fix the issue and travis would save cache on error. test for build error: https://travis-ci.org/bitcoin/bitcoin/builds/429172128 Tree-SHA512: fb8beb97928e10932c695d1884948bf8972a6501042d5212111fba1f258160d813a4c6cc72e9da78f2acd9518382c21943347b820d8e15b5eb874e7707c928b2
Member
|
The tests fail, but travis is green: https://travis-ci.org/bitcoin/bitcoin/jobs/466818326#L2966 Not sure if this is related to this pull request? |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 13, 2018
… it fail fc91c1f Revert "travis: Save cache on build error" (Chun Kuan Lee) Pull request description: The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail. This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command. Sorry for ruin the travis ci system in bitcoin#14231 Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010 Tree-SHA512: 4d9d144fe4c7038b4eff6bf8496e821af603d81677142c0884ed52aea6ce3a50150669be4fdad72a5d372456a33a2452d75ec35e8a7ec2bc4bdfbeaeb93e9acb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current travis setup, the job will terminate immediately if an error occur. There is no chance to save the cache. This was accidentally introduced by #13863. This PR is to fix the issue and travis would save cache on error.
test for build error: https://travis-ci.org/bitcoin/bitcoin/builds/429172128