docs: Add config file docs to '-help' messages#14427
Closed
hebasto wants to merge 1 commit intobitcoin:masterfrom
Closed
docs: Add config file docs to '-help' messages#14427hebasto wants to merge 1 commit intobitcoin:masterfrom
hebasto wants to merge 1 commit intobitcoin:masterfrom
Conversation
This adds a suitable user documentation about configuration file. The `bitcoin-qt -version` output formatting has been fixed as well.
Contributor
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
promag
reviewed
Oct 8, 2018
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
I feel this doesn't belong to -help?
| { | ||
| return strprintf(_("All command-line options (except for '%s') may be specified in a configuration file, and all configuration file options may also be specified on the command line. " | ||
| "Command-line options override values set in the configuration file."), | ||
| "-conf") + |
Member
Author
There was a problem hiding this comment.
This is done on purpose to not translate a command line option.
| "\n" + | ||
| "\n" + | ||
| strprintf(_("The configuration file is not automatically created; you can create it using your favorite plain-text editor. " | ||
| "By default, %s will look for a file named '%s' in the %s data directory, but both the data directory and the configuration file path may be changed using the '%s' and '%s' command-line arguments."), |
Contributor
There was a problem hiding this comment.
Could drop strBitcoinClient and make this By default a file named '%s' in the %s data director...?
Member
Author
There was a problem hiding this comment.
This wording is quoted from BITCOIN.CONF(5).
Why do you think the dropping strBitcoinClient out is preferable?
Contributor
There was a problem hiding this comment.
IMO it's independent of the binary so could drop it. Beside that manpage is from bitcoind package.
Member
Author
|
@promag
Which other piece of user documentation will be more suitable? |
Contributor
|
@hebasto in my opinion |
Member
|
I too think this is overkill; like with other programs |
Member
Author
|
Closing in favour of #14497. |
laanwj
added a commit
that referenced
this pull request
Oct 20, 2018
1fb3c16 Add `doc/bitcoin-conf.md` (Hennadii Stepanov) Pull request description: From the IRC: > 2018-10-16T05:35:03 \<wumpus\> if something can be solved by better documentation, please work on documentation! > 2018-10-16T05:35:12 \<wumpus\> don't change the code instead Refs: - #14370 - #14427 - #14494 Based on the BITCOIN.CONF(5) manual page written by Micah Anderson \<[email protected]\> for the Debian system. Tree-SHA512: 16393c9073c027fa1c46f8b59651e60b9a3159b3aeb9b3102040c292d2787f32b1ead5977957ac3ac0759a4bf626650a2325b68ad84320964ac089ffc2d3b4f4
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
1fb3c16 Add `doc/bitcoin-conf.md` (Hennadii Stepanov) Pull request description: From the IRC: > 2018-10-16T05:35:03 \<wumpus\> if something can be solved by better documentation, please work on documentation! > 2018-10-16T05:35:12 \<wumpus\> don't change the code instead Refs: - bitcoin#14370 - bitcoin#14427 - bitcoin#14494 Based on the BITCOIN.CONF(5) manual page written by Micah Anderson \<[email protected]\> for the Debian system. Tree-SHA512: 16393c9073c027fa1c46f8b59651e60b9a3159b3aeb9b3102040c292d2787f32b1ead5977957ac3ac0759a4bf626650a2325b68ad84320964ac089ffc2d3b4f4
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
1fb3c16 Add `doc/bitcoin-conf.md` (Hennadii Stepanov) Pull request description: From the IRC: > 2018-10-16T05:35:03 \<wumpus\> if something can be solved by better documentation, please work on documentation! > 2018-10-16T05:35:12 \<wumpus\> don't change the code instead Refs: - bitcoin#14370 - bitcoin#14427 - bitcoin#14494 Based on the BITCOIN.CONF(5) manual page written by Micah Anderson \<[email protected]\> for the Debian system. Tree-SHA512: 16393c9073c027fa1c46f8b59651e60b9a3159b3aeb9b3102040c292d2787f32b1ead5977957ac3ac0759a4bf626650a2325b68ad84320964ac089ffc2d3b4f4
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 3, 2021
1fb3c16 Add `doc/bitcoin-conf.md` (Hennadii Stepanov) Pull request description: From the IRC: > 2018-10-16T05:35:03 \<wumpus\> if something can be solved by better documentation, please work on documentation! > 2018-10-16T05:35:12 \<wumpus\> don't change the code instead Refs: - bitcoin#14370 - bitcoin#14427 - bitcoin#14494 Based on the BITCOIN.CONF(5) manual page written by Micah Anderson \<[email protected]\> for the Debian system. Tree-SHA512: 16393c9073c027fa1c46f8b59651e60b9a3159b3aeb9b3102040c292d2787f32b1ead5977957ac3ac0759a4bf626650a2325b68ad84320964ac089ffc2d3b4f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a suitable user documentation about configuration file.
The
bitcoin-qt -versionoutput formatting has been fixed as well.Refs:
utils and libraries: Allow values quoting in config files #14370 (comment)
bitcoin.conf.5 manpage missing #9944
Some small modifications made outputs of
bitcoindandbitcoin-qtthe same:And the output on GUI (menu ->
Help->Command-line options):