RPC: add weight to mempool entry output#14649
Closed
luke-jr wants to merge 3 commits intobitcoin:masterfrom
Closed
RPC: add weight to mempool entry output#14649luke-jr wants to merge 3 commits intobitcoin:masterfrom
luke-jr wants to merge 3 commits intobitcoin:masterfrom
Conversation
luke-jr
force-pushed
the
rpc_mempoolentry_weight
branch
from
fed6766 to
092defc
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
utACK 092defc |
Contributor
|
utACK 092defc. Could have release note. |
Contributor
|
Tested ACK 092defc |
promag
reviewed
Nov 12, 2018
Contributor
There was a problem hiding this comment.
@luke-jr the following also get weight key in the result:
getrawmempool,getmempoolancestorsandgetmempooldescendantswithverbose=true/rest/mempool/contents.json.
Do you mind adding tests for those (at least test it's numeric) and add release notes?
Contributor
| Needs rebase |
Member
|
Given this had utACKs, @luke-jr would you like to rebase and add some release notes. |
Member
|
I've rebased and added release-notes in #16647. |
maflcko
pushed a commit
that referenced
this pull request
Aug 20, 2019
17d178f doc: add release-notes for getmempoolentry weight field addition (fanquake) 9c9cc2b qa: Add RPC tests for weight in mempool entry (Daniel Edgecumbe) 54aaa78 RPC: add weight to mempool entry output (Daniel Edgecumbe) Pull request description: Rebase of #14649 (which itself was a rebase of #11256). Squash the two test related commits, and swapped out `size` usage for `vsize`. Added a commit with release notes. ACKs for top commit: emilengler: Concept ACK 17d178f instagibbs: utACK 17d178f meshcollider: utACK 17d178f Tree-SHA512: 1d354c9837e0ad0afa40325de9329b9e62688d5eab4d9e1cf9b46d8ae29d08f42d903ab37a41751c2ea8f9034231b21095881b1f5d911cb542b8b06bc85dc7cd
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 22, 2019
17d178f doc: add release-notes for getmempoolentry weight field addition (fanquake) 9c9cc2b qa: Add RPC tests for weight in mempool entry (Daniel Edgecumbe) 54aaa78 RPC: add weight to mempool entry output (Daniel Edgecumbe) Pull request description: Rebase of bitcoin#14649 (which itself was a rebase of bitcoin#11256). Squash the two test related commits, and swapped out `size` usage for `vsize`. Added a commit with release notes. ACKs for top commit: emilengler: Concept ACK 17d178f instagibbs: utACK bitcoin@17d178f meshcollider: utACK 17d178f Tree-SHA512: 1d354c9837e0ad0afa40325de9329b9e62688d5eab4d9e1cf9b46d8ae29d08f42d903ab37a41751c2ea8f9034231b21095881b1f5d911cb542b8b06bc85dc7cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased and fixed outstanding issues in #11256
Also removed some unnecessary refactoring to simplify review