Tests: IsReachable is the inverse of IsLimited (DRY)#15044
Tests: IsReachable is the inverse of IsLimited (DRY)#15044mmachicao wants to merge 2 commits intobitcoin:masterfrom mmachicao:net_contract_test
Conversation
| { | ||
| if (fListen && pnode->fSuccessfullyConnected) | ||
| { | ||
| if (fListen && pnode->fSuccessfullyConnected) { |
There was a problem hiding this comment.
We run https://github.com/bitcoin/bitcoin/tree/master/contrib/devtools#clang-format-diffpy only on the diff and not the whole file.
There was a problem hiding this comment.
Hi MarkoFalke. I am afraid, appveyor will reject a file that is not fully formatted according to clang rules. Better bite the bullet now?
There was a problem hiding this comment.
We don't check formatting in appveyor. Do you have a failing build to link to?
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Closing this one. Am providing another pull request with the minimal change set. Note: Jsut reviewed. The conflicts with other pull requests are related exclusively to the application of clang format. Will create a pull request with clang format exclusively for my changed lines. |
…ncludes unit tests 6dc4593 IsReachable is the inverse of IsLimited (DRY). Includes unit tests (marcaiaf) Pull request description: IsReachable is the inverse of IsLimited, but the implementation is duplicated (DRY) - Changed the implementation accordingly. - Added unit tests to document behavior and relationship - My modification in net.cpp applies only to IsReachable. - Applied clang-format-diffpy Created new pull request to avoid the mess with: #15044 Checked with supposedly conflicting PRs mentioned in the old PR. No conflicts with the specific changes in this PR. Tree-SHA512: b132dec6cc2c788ebe4f63f228d78f441614e156743b17adebc990de0180a5872874d2724c86eeaa470b4521918bd137b0e33ebcaae77c5efc1f0d56104f6c87
…DRY). Includes unit tests 6dc4593 IsReachable is the inverse of IsLimited (DRY). Includes unit tests (marcaiaf) Pull request description: IsReachable is the inverse of IsLimited, but the implementation is duplicated (DRY) - Changed the implementation accordingly. - Added unit tests to document behavior and relationship - My modification in net.cpp applies only to IsReachable. - Applied clang-format-diffpy Created new pull request to avoid the mess with: bitcoin#15044 Checked with supposedly conflicting PRs mentioned in the old PR. No conflicts with the specific changes in this PR. Tree-SHA512: b132dec6cc2c788ebe4f63f228d78f441614e156743b17adebc990de0180a5872874d2724c86eeaa470b4521918bd137b0e33ebcaae77c5efc1f0d56104f6c87
4 participants
IsReachable is the inverse of IsLimited, but the implementation is duplicated (DRY)