http: Fail initialization when any bind fails (0.17)#15050
Closed
laanwj wants to merge 1 commit intobitcoin:0.17from
Closed
http: Fail initialization when any bind fails (0.17)#15050laanwj wants to merge 1 commit intobitcoin:0.17from
laanwj wants to merge 1 commit intobitcoin:0.17from
Conversation
Currently the HTTP server initialization (`HTTPBindAddresses`) fails only when *all* bindings fail. So if multiple binds are specified (`127.0.0.1` and `::1` by defeault) and one succeeds and the other fails, the latter is essentially ignored. This commit changes the error behavior to fail *if not all* binds could be performed, which I think is more in line with how software normally handles this and what users expect.
Member
Author
|
Let's see if we can reproduce the problem w/ Travis test coverage on master @luke-jr mentions here #14968 (comment) |
Member
Author
|
This is interesting, apparently the first test What is different in the environment for 0.17 that could explain this? The libevent version? The test environment? I didn't see any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14968 to 0.17 branch.