tests: Make test updatecoins_simulation_test deterministic#15327
Merged
maflcko merged 1 commit intobitcoin:masterfrom Feb 5, 2019
Merged
tests: Make test updatecoins_simulation_test deterministic#15327maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
utACK f72aea270304808815757f523ef5867e53cd1b59 |
Empact
reviewed
Feb 3, 2019
practicalswift
force-pushed
the
SeedInsecureRand(true);
branch
from
f72aea2 to
ef0b012
Compare
practicalswift
changed the title
Contributor
|
utACK ef0b012 |
Contributor
Author
|
@MarcoFalke Would you mind re-reviewing? It gets easier to tackle the hard non-determinism cases with the noise from these trivial cases out of the way :-) |
Member
|
I'd prefer to do make more than one test deterministic in its coverage, otherwise this will end up in a flood of pull requests. Unless of course one of the fixes is potentially too controversial (e.g. modifies validation code or other Core code) |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Feb 5, 2019
…erministic ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift) Pull request description: Make test `updatecoins_simulation_test` deterministic. Can be verified using `contrib/test_deterministic_coverage.sh` introduced in bitcoin#15296. Related: * bitcoin#15296: "tests: Add script checking for deterministic line coverage in unit tests" * bitcoin#15324: "test: Make bloom tests deterministic" * bitcoin#14343: "coverage reports non-deterministic" Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 18, 2020
Summary: Backport of core [[bitcoin/bitcoin#15327 | PR15327]]. Test Plan: ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6620
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Oct 16, 2020
Summary: Backport of core [[bitcoin/bitcoin#15327 | PR15327]]. Test Plan: ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6620
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 29, 2021
…erministic ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift) Pull request description: Make test `updatecoins_simulation_test` deterministic. Can be verified using `contrib/test_deterministic_coverage.sh` introduced in bitcoin#15296. Related: * bitcoin#15296: "tests: Add script checking for deterministic line coverage in unit tests" * bitcoin#15324: "test: Make bloom tests deterministic" * bitcoin#14343: "coverage reports non-deterministic" Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make test
updatecoins_simulation_testdeterministic.Can be verified using
contrib/test_deterministic_coverage.shintroduced in #15296.Related: