[Docs] Small updates to getrawtransaction description#15332
[Docs] Small updates to getrawtransaction description#15332maflcko merged 1 commit intobitcoin:masterfrom
Conversation
|
Question about whitespace 😝- Ex: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpcdump.cpp#L113 & https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpcdump.cpp#L1196 However, this one doesn't extra-indent the first line: |
|
There is no guideline about whitespace as long as you stick to either rule-of-thumb:
|
|
ACK |
amitiuttarwar
force-pushed
the
get_transaction_docs
branch
from
51d7868 to
35c7eb0
Compare
|
hmm, ok went with format script if indentation was not intentional. added getmempoolentry reference. |
|
utACK 35c7eb045f79b5a556c9d17eddf3bf59d0d1b55f |
amitiuttarwar
force-pushed
the
get_transaction_docs
branch
from
35c7eb0 to
4701239
Compare
|
This is ready. |
| blockhash is provided, check the mempool. 3. If no blockhash is | ||
| provided but txindex is enabled, also check txindex. | ||
| - The `getrawtransaction` RPC & REST endpoints no longer check the | ||
| unspent UTXO set for a transaction. The remaining behaviors are as |
There was a problem hiding this comment.
Nit: Perhaps this is fine in American English, but 'The remaining behaviors are...' sounds a little odd to me. 'The new behavior is...' sounds more natural.
There was a problem hiding this comment.
I disagree, calling the behavior new seems misleading.
There was a problem hiding this comment.
I'll let others comment. ACK either way.
…ption 4701239 [Docs] Small updates to getrawtransaction description (Amiti Uttarwar) Pull request description: As per review comments on bitcoin#15159 Tree-SHA512: 0bbbe956b47d177f7e67c5ab2048287783327d9e07a679d64d79aee3ea8633e769f75b59d3dbce517924ba5d64d6c44f26bf49e16d40612463e460ad1a238129
5 participants
As per review comments on #15159