[depends] update to Boost 1.70 by Sjors · Pull Request #15461 · bitcoin/bitcoin

Sjors · 2019-02-22T10:12:31Z

Version 1.70 is most recent.

Versions needed for:

1.66: [WIP] 64 bit iOS device support #12557: fixes the single arm64 configuration (06ee5b5)

Sjors · 2019-02-22T10:14:11Z

Other than iOs support, are there are any other reasons for updating the Boost version? Otherwise this can wait until #12557 is closer to merge readiness.

@fanquake suggested bumping straight to 1.69

maflcko · 2019-02-22T13:31:35Z

This is sporadically updated to the latest version, so might as well do 1.69

Sjors · 2019-02-22T13:47:32Z

Mmm, Travis build for 32-bit ARM is unhappy:

undefined reference to `boost::system::system_category()

I'll try if 1.69 magically makes that problem go away.

fanquake · 2019-02-23T05:52:53Z

Concept ACK. Will review release notes and test depends builds etc.

fanquake · 2019-03-15T06:42:53Z

Relevant release notes from Boost 1.65.0 -> 1.69.0:

1.69.0

Filesystem

Fixed crashes in boost::filesystem::copy due to undefined behavior in the implementation.
Fixed undefined behavior in boost::filesystem::directory_iterator implementation.
Fixed MSVC warnings about narrowing conversions.

System

Boost.System is now header-only. A stub library is still built for compatibility, but linking to it is no longer necessary.
The destructor of error_category is now protected and no longer virtual. This is a potentially breaking change, but its impact is expected to be limited.

1.68.0

Boost.WinAPI has been updated to target Windows 7 by default, where possible. In previous releases Windows Vista was the default.

Test

Breaking change: The master_test_suite_t object is no more copyable

1.67.0

Filesystem

Fix static initialization issue that caused a crash if path operations were used before main()

Test

Breaking change: Adding test cases with the same name to the same test suite is now reported as an error. See the changes log for more details.

1.66.0

Thread

Many Windows related fixes.

1.65.0

Test

C++17 compatibility (tested on VS2017)

Breaking Changes

Some API changes for the loggers
Deprecating BOOST_GLOBAL_FIXTURE in favor of BOOST_TEST_GLOBAL_FIXTURE and BOOST_TEST_GLOBAL_CONFIGURATION.

promag · 2019-04-29T21:25:45Z

Concept ACK.

Then this could be updated:

bitcoin/src/wallet/walletutil.cpp

Lines 70 to 72 in ce67620

    
           // Get wallet path relative to walletdir by removing walletdir from the wallet path. 
        
           // This can be replaced by boost::filesystem::lexically_relative once boost is bumped to 1.60. 
        
           const fs::path path = it->path().string().substr(offset);

Edit: this too https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md#L9

hebasto · 2019-05-02T08:50:16Z

Concept ACK.
Agree with @promag's comments.

Sjors · 2019-05-02T10:12:09Z

Rebased and adjusted the version in dependencies.md. We can't change walletutil.cpp because the minimum Boost version (1.47.0) doesn't change with this PR. Changing the minimum version can be done in a followup, but there's no urgent need afaik.

Sjors · 2019-05-03T13:17:53Z

I switched from Boost 1.69 to 1.70

practicalswift · 2019-05-03T13:23:22Z

Concept ACK

DrahtBot · 2019-05-03T15:22:07Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#10102 ([experimental] Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot · 2019-05-05T03:28:21Z

Gitian builds for commit 24dfcf3 (master):

3d60ebc8cbfd7f4933063f9d69639e64... bitcoin-0.18.99-osx-unsigned.dmg
a4e22cda5ea46ee15e54b7b69b8b27ce... bitcoin-0.18.99-osx64.tar.gz
a4980eaf59f90a611a444c1b76c5b9b0... bitcoin-0.18.99-win32-debug.zip
4c853b576a4cc6fa1ae8d1011ef8bda6... bitcoin-0.18.99-win32-setup-unsigned.exe
bb29d6a197f89a73655204232b180dd1... bitcoin-0.18.99-win32.zip
5f44cfdf87788d786f56d5cbac2838c1... bitcoin-0.18.99-win64-debug.zip
49d619f33ed264a08a1d7139e47c839f... bitcoin-0.18.99-win64-setup-unsigned.exe
e25c18928673adca14a8fe554671ee98... bitcoin-0.18.99-win64.zip
0a327e5f718504e19a6e1942650fe554... bitcoin-core-osx-0.19-res.yml
40e4f7e87e4089d9c4770abd898d9ce3... bitcoin-core-win-0.19-res.yml
5291ced866d1bf095152ced17009ac19... bitcoin-linux-build.log
762ca6d579a8704366c076990183d925... bitcoin-osx-build.log
18f4ab45d17f755f95ede31a1a4107d9... bitcoin-win-build.log

Gitian builds for commit c0d07f6dc9f7a39a4331d5a2af5a168c4ef57cd2 (master and this pull):

87f01454af701217107210735efde480... bitcoin-0.18.99-osx-unsigned.dmg
36bce180dbd1d80bdd55adb04f27e62a... bitcoin-0.18.99-osx64.tar.gz
bce6e6a85b821fa8e46dbed16cce1e5e... bitcoin-0.18.99-win32-debug.zip
819dface11bafaf303cb94fd19dc0ac4... bitcoin-0.18.99-win32-setup-unsigned.exe
c6126945df3871b877f79ca8836148df... bitcoin-0.18.99-win32.zip
4d029f896b2d3427134f0633a77af92a... bitcoin-0.18.99-win64-debug.zip
545755f7e78e9de30ad63b416175ca85... bitcoin-0.18.99-win64-setup-unsigned.exe
d48118c1379e810afb2a45edb120e814... bitcoin-0.18.99-win64.zip
2b6af7cf5d67cd8f8e7ddec4b87c7db9... bitcoin-core-osx-0.19-res.yml
ef6744aac46d18e0fdbef40bbd75d68d... bitcoin-core-win-0.19-res.yml
7cebe983431a0daabdc791206bb81321... bitcoin-linux-build.log
34e21d53dc58434bb70159fe97ce81f2... bitcoin-osx-build.log
85fa63a4d89064241ff55449cec24be8... bitcoin-win-build.log

Sjors · 2019-05-06T10:52:19Z

Very lightly tested the macOS Gitian QT build.

laanwj · 2019-06-06T11:43:33Z

ACK 2620e24, let's do this early in the 0.19 cycle

2620e24 [depends] boost: update to 1.70 (Sjors Provoost) Pull request description: Version [1.70](https://www.boost.org/users/history/version_1_70_0.html) is most recent. Versions needed for: * 1.66: #12557: fixes the single arm64 configuration ([06ee5b5](ruslo/hunter@06ee5b5)) ACKs for commit 2620e2: Tree-SHA512: 6e0174f1d92c2c24314c0689d4809e048914f8f42d17aa73799f5ee232169e0dd0ed71f5f973903c44c08309f2837c629c493f15e5c31ec6c7bd1daae5f3b25f

laanwj · 2019-06-06T11:53:22Z

build-aux/m4/ax_boost_system.m4

            fi
            if test "x$ax_lib" = "x"; then
-                AC_MSG_ERROR(Could not find a version of the boost_system library!)
+                AC_MSG_ERROR(Could not find a version of the library!)


This reverts (part of) 25333a2 but I don't know if we care.

I didn't realize we were using a patch on top of https://www.gnu.org/software/autoconf-archive/ax_boost_base.html

Oops: #17010

maflcko · 2019-06-06T13:24:51Z

It seems that not even debian experimental is at 1.70. I guess that means we are the beta testers? Let's hope debian ships it within the next couple of months.

kristapsk · 2019-06-06T14:34:16Z

On Gentoo it exists but is masked (not stable).

2620e24 [depends] boost: update to 1.70 (Sjors Provoost) Pull request description: Version [1.70](https://www.boost.org/users/history/version_1_70_0.html) is most recent. Versions needed for: * 1.66: bitcoin#12557: fixes the single arm64 configuration ([06ee5b5](ruslo/hunter@06ee5b5)) ACKs for commit 2620e2: Tree-SHA512: 6e0174f1d92c2c24314c0689d4809e048914f8f42d17aa73799f5ee232169e0dd0ed71f5f973903c44c08309f2837c629c493f15e5c31ec6c7bd1daae5f3b25f

refs bitcoin/bitcoin#15461

maflcko · 2019-07-08T20:07:03Z

For reference:

https://packages.debian.org/source/sid/boost-defaults
https://apps.fedoraproject.org/packages/boost/overview/
https://packages.ubuntu.com/eoan/libboost-all-dev
https://www.archlinux.org/packages/extra/x86_64/boost/
https://packages.gentoo.org/packages/dev-libs/boost

Summary: Backport of core [[bitcoin/bitcoin#15461 | PR15461]]. This PR is known to cause 2 issues: - The build (native) on ARM might be broken: bitcoin/bitcoin#17010 - The error messages are not helpful: bitcoin/bitcoin#16803 None of these issues are critical. I kept (adapted) the patch to work around the first issue. It doesn't provide a very solid guarantee but it can't hurt. The second issue will be fixed in a future backport. Note that due to boost cmake update, it is now required to set `Boost_USE_STATIC_RUNTIME` to `ON`. Test Plan: make make check Run the Gitian builds. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5623

2620e24 [depends] boost: update to 1.70 (Sjors Provoost) Pull request description: Version [1.70](https://www.boost.org/users/history/version_1_70_0.html) is most recent. Versions needed for: * 1.66: bitcoin#12557: fixes the single arm64 configuration ([06ee5b5](ruslo/hunter@06ee5b5)) ACKs for commit 2620e2: Tree-SHA512: 6e0174f1d92c2c24314c0689d4809e048914f8f42d17aa73799f5ee232169e0dd0ed71f5f973903c44c08309f2837c629c493f15e5c31ec6c7bd1daae5f3b25f

Sjors mentioned this pull request Feb 22, 2019

[WIP] 64 bit iOS device support #12557

Closed

fanquake added the Build system label Feb 22, 2019

Sjors force-pushed the 2019/02/depends_boost branch from c28b53c to b4ca5d5 Compare February 22, 2019 13:01

maflcko added this to the 0.19.0 milestone Feb 22, 2019

maflcko added the Needs gitian build label Feb 22, 2019

Sjors changed the title ~~[depends] update to Boost 1.66~~ [depends] update to Boost 1.69 Feb 22, 2019

Sjors force-pushed the 2019/02/depends_boost branch from b4ca5d5 to 43eccb0 Compare February 22, 2019 13:53

maflcko removed the Needs gitian build label Feb 22, 2019

maflcko added the Needs gitian build label Feb 23, 2019

DrahtBot removed the Needs gitian build label Feb 24, 2019

bitcoin deleted a comment from DrahtBot Apr 30, 2019

Sjors force-pushed the 2019/02/depends_boost branch from 43eccb0 to 19ca64a Compare May 2, 2019 10:07

maflcko added the Needs gitian build label May 2, 2019

[depends] boost: update to 1.70

2620e24

Sjors force-pushed the 2019/02/depends_boost branch from 19ca64a to 2620e24 Compare May 3, 2019 12:22

Sjors changed the title ~~[depends] update to Boost 1.69~~ [depends] update to Boost 1.70 May 3, 2019

DrahtBot removed the Needs gitian build label May 5, 2019

laanwj merged commit 2620e24 into bitcoin:master Jun 6, 2019

laanwj reviewed Jun 6, 2019

View reviewed changes

Sjors deleted the 2019/02/depends_boost branch June 7, 2019 12:18

eugene-sy added a commit to meritlabs/merit that referenced this pull request Jun 11, 2019

upgrade boost

8b8eb89

refs bitcoin/bitcoin#15461

This was referenced Oct 1, 2019

Missing Boost::System on ARM Ubuntu 18.04 #17010

Closed

AX_BOOST_BASE: fix Boost detection on some platforms autoconf-archive/autoconf-archive#198

Closed

maflcko mentioned this pull request Dec 13, 2019

configure: error: No working boost sleep implementation found. #17478

Closed

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Conversation

Sjors commented Feb 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sjors commented Feb 22, 2019

Uh oh!

maflcko commented Feb 22, 2019

Uh oh!

Sjors commented Feb 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanquake commented Feb 23, 2019

Uh oh!

fanquake commented Mar 15, 2019

Filesystem

System

Test

Filesystem

Test

Thread

Test

Uh oh!

promag commented Apr 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented May 2, 2019

Uh oh!

Sjors commented May 2, 2019

Uh oh!

Sjors commented May 3, 2019

Uh oh!

practicalswift commented May 3, 2019

Uh oh!

DrahtBot commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

DrahtBot commented May 5, 2019

Uh oh!

Sjors commented May 6, 2019

Uh oh!

laanwj commented Jun 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko commented Jun 6, 2019

Uh oh!

kristapsk commented Jun 6, 2019

Uh oh!

maflcko commented Jul 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Sjors commented Feb 22, 2019 •

edited

Loading

Sjors commented Feb 22, 2019 •

edited

Loading

promag commented Apr 29, 2019 •

edited

Loading

DrahtBot commented May 3, 2019 •

edited

Loading