[rpc] Remove deprecated rpc warnings#15642
Merged
laanwj merged 3 commits intobitcoin:masterfrom Mar 23, 2019
Merged
Conversation
signrawtransaction was deprecated in 0.17 and removed in 0.18. A warning was left in place to tell users to migrate to using signrawtransactionswithwallet or signrawtransactionwithkey. Remove the warning now that it's been two releases since the method was removed.
This functionality was removed in v0.18.
Contributor
Author
|
One could argue that the second commit Remove deprecated functionality message from validateaddress help should be backported to 0.18, but I think it's so minor that it's not worth it. |
Contributor
|
Maybe also replace in https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#L955? |
Member
|
ACK on the doc-backport |
jnewbery
changed the title
Contributor
Author
Done |
Member
|
utACK 947f73c |
1 similar comment
Member
|
utACK 947f73c |
Member
|
utACK 947f73c |
Contributor
|
utACK 947f73c. |
laanwj
added a commit
that referenced
this pull request
Mar 23, 2019
947f73c [docs] remove reference to signrawtransaction in the developer docs. (John Newbery) 7b6616b [rpc] Remove deprecated functionality message from validateaddress help (John Newbery) 839c3f7 [rpc] Remove signrawtransaction warning (John Newbery) Pull request description: Removes some deprecated code from the RPCs: - signrawtransaction was deprecated in 0.17 and removed in 0.18. A warning message was left in place to advise users to use signrawtransactionwithwallet and signrawtransactionwithkey. That warning can now be removed. - validateaddress had some functionality deprecated in 0.17 and removed in 0.18. The help text for that functionality was not removed in 0.18 and can be removed now. Tree-SHA512: 981678a697954ff2c392752e5a183b4b12c4eb94f55766ee1aa97a70d300668237db8fc5748c2772869d0155ba4a93e38817887b98160ee972a6f6ee94e3f7d9
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Oct 16, 2021
947f73c [docs] remove reference to signrawtransaction in the developer docs. (John Newbery) 7b6616b [rpc] Remove deprecated functionality message from validateaddress help (John Newbery) 839c3f7 [rpc] Remove signrawtransaction warning (John Newbery) Pull request description: Removes some deprecated code from the RPCs: - signrawtransaction was deprecated in 0.17 and removed in 0.18. A warning message was left in place to advise users to use signrawtransactionwithwallet and signrawtransactionwithkey. That warning can now be removed. - validateaddress had some functionality deprecated in 0.17 and removed in 0.18. The help text for that functionality was not removed in 0.18 and can be removed now. Tree-SHA512: 981678a697954ff2c392752e5a183b4b12c4eb94f55766ee1aa97a70d300668237db8fc5748c2772869d0155ba4a93e38817887b98160ee972a6f6ee94e3f7d9
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Oct 21, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
947f73c [docs] remove reference to signrawtransaction in the developer docs. (John Newbery) 7b6616b [rpc] Remove deprecated functionality message from validateaddress help (John Newbery) 839c3f7 [rpc] Remove signrawtransaction warning (John Newbery) Pull request description: Removes some deprecated code from the RPCs: - signrawtransaction was deprecated in 0.17 and removed in 0.18. A warning message was left in place to advise users to use signrawtransactionwithwallet and signrawtransactionwithkey. That warning can now be removed. - validateaddress had some functionality deprecated in 0.17 and removed in 0.18. The help text for that functionality was not removed in 0.18 and can be removed now. Tree-SHA512: 981678a697954ff2c392752e5a183b4b12c4eb94f55766ee1aa97a70d300668237db8fc5748c2772869d0155ba4a93e38817887b98160ee972a6f6ee94e3f7d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some deprecated code from the RPCs: