contrib: gh-merge: Include ACKs in merge commit#15643
Conversation
|
|
|
With review comments I mean only the ACKs (adjusted title) |
|
Example: |
Oh that does sound good! |
|
Nice! utACK fa1c073 |
|
Concept ACK |
|
Concept ACK Nit: If I'm reading the code right also NACK:s will be included under the heading "ACKs for commit […]". If that is intentional then perhaps change heading to "ACK/NACKs for commit […]" to clarify? |
|
@practicalswift No, it would only show up if you NACK+the commit id, which is rarely (never) done. |
|
Concept ACK |
|
@MarcoFalke Thanks for the clarification. I missed the utACK fa1c073 (nit: a run with your |
|
utACK fa1c073 |
fa1c073 contrib: gh-merge: Include review comments in merge commit (MarcoFalke) Pull request description: This includes all up-to-date ACKs in the merge commit for reference Tree-SHA512: 32c9352d884f9ecf94940f50f2921fc9fc026083c120f54d0651a41814872e852aee8d0c4ad5bcd03292329f05d76fcb7bac11741e1dd3bf417211a186005afb
Github-Pull: bitcoin#15643 Rebased-From: fa1c073
fa1c073 contrib: gh-merge: Include review comments in merge commit (MarcoFalke) Pull request description: This includes all up-to-date ACKs in the merge commit for reference Tree-SHA512: 32c9352d884f9ecf94940f50f2921fc9fc026083c120f54d0651a41814872e852aee8d0c4ad5bcd03292329f05d76fcb7bac11741e1dd3bf417211a186005afb
This includes all up-to-date ACKs in the merge commit for reference